chrome/browser/chromeos/settings/device_settings_provider_unittest.cc - Issue 2736903004: Add sound volume to device attribute reporting

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/settings/device_settings_provider_unittest.cc

Issue 2736903004: Add sound volume to device attribute reporting (Closed)

Patch Set: Fixed tests (initialize CrasAudioHandler), added sound volume test Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/chromeos/policy/device_status_collector.cc ('K') | « chrome/browser/chromeos/settings/device_settings_provider.cc ('k') | chrome/test/data/policy/policy_test_cases.json » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/chromeos/settings/device_settings_provider_unittest.cc

diff --git a/chrome/browser/chromeos/settings/device_settings_provider_unittest.cc b/chrome/browser/chromeos/settings/device_settings_provider_unittest.cc

index cf5078469531fcf1ed3152322773e30d8b416009..7da1789bc8d880f3d7d807a9ef8f5508d72a0cea 100644

--- a/chrome/browser/chromeos/settings/device_settings_provider_unittest.cc

+++ b/chrome/browser/chromeos/settings/device_settings_provider_unittest.cc

@@ -83,6 +83,7 @@ class DeviceSettingsProviderTest : public DeviceSettingsTestBase {

proto->set_report_session_status(enable_reporting);

proto->set_report_os_update_status(enable_reporting);

proto->set_report_running_kiosk_app(enable_reporting);

+ proto->set_report_sound_volume(enable_reporting);

proto->set_device_status_frequency(frequency);

device_policy_.Build();

device_settings_test_helper_.set_policy_blob(device_policy_.GetBlob());

@@ -155,7 +156,8 @@ class DeviceSettingsProviderTest : public DeviceSettingsTestBase {

kReportDeviceHardwareStatus,

kReportDeviceSessionStatus,

kReportOsUpdateStatus,

- kReportRunningKioskApp

+ kReportRunningKioskApp,

+ kReportSoundVolume

};

const base::Value expected_enable_value(expected_enable_state);