Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1363)

Unified Diff: chrome/browser/chromeos/policy/device_status_collector.h

Issue 2736903004: Add sound volume to device attribute reporting (Closed)
Patch Set: Fixed tests (initialize CrasAudioHandler), added sound volume test Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/policy/device_status_collector.h
diff --git a/chrome/browser/chromeos/policy/device_status_collector.h b/chrome/browser/chromeos/policy/device_status_collector.h
index cafec8763790c4303a80f3bbb4259a8ba662cec9..a8e9cbe30ca9d1b6823218ae38659e909e94490c 100644
--- a/chrome/browser/chromeos/policy/device_status_collector.h
+++ b/chrome/browser/chromeos/policy/device_status_collector.h
@@ -199,6 +199,7 @@ class DeviceStatusCollector {
enterprise_management::DeviceStatusReportRequest* status);
bool GetRunningKioskApp(
enterprise_management::DeviceStatusReportRequest* status);
+ bool GetSoundVolume(enterprise_management::DeviceStatusReportRequest* status);
// Helpers for the various portions of SESSION STATUS. Return true if they
// actually report any status. Functions that queue async queries take
@@ -275,6 +276,7 @@ class DeviceStatusCollector {
bool report_kiosk_session_status_ = false;
bool report_os_update_status_ = false;
bool report_running_kiosk_app_ = false;
+ bool report_sound_volume_ = false;
std::unique_ptr<chromeos::CrosSettings::ObserverSubscription>
version_info_subscription_;
@@ -294,6 +296,8 @@ class DeviceStatusCollector {
os_update_status_subscription_;
std::unique_ptr<chromeos::CrosSettings::ObserverSubscription>
running_kiosk_app_subscription_;
+ std::unique_ptr<chromeos::CrosSettings::ObserverSubscription>
+ sound_volume_subscription_;
Andrew T Wilson (Slow) 2017/03/09 15:56:34 See my prev comment - probably makes sense to just
// Task runner in the creation thread where responses are sent to.
scoped_refptr<base::SequencedTaskRunner> task_runner_;

Powered by Google App Engine
This is Rietveld 408576698