Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Unified Diff: chrome/browser/ui/ash/launcher/chrome_launcher_controller_browsertest.cc

Issue 27369004: Change GetBrowserItemIndex() to GetLauncherItemIndexForType() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fix clang error Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/ash/launcher/chrome_launcher_controller.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/ash/launcher/chrome_launcher_controller_browsertest.cc
diff --git a/chrome/browser/ui/ash/launcher/chrome_launcher_controller_browsertest.cc b/chrome/browser/ui/ash/launcher/chrome_launcher_controller_browsertest.cc
index c9f37ca00a28dd3784898cbde6f4f958c9939bc5..d69d249aaab95ce41e99e70608dd4275d14a6122 100644
--- a/chrome/browser/ui/ash/launcher/chrome_launcher_controller_browsertest.cc
+++ b/chrome/browser/ui/ash/launcher/chrome_launcher_controller_browsertest.cc
@@ -12,7 +12,7 @@
#include "ash/launcher/launcher.h"
#include "ash/launcher/launcher_button.h"
#include "ash/launcher/launcher_model.h"
-#include "ash/shelf/shelf_util.h"
+#include "ash/launcher/launcher_model_util.h"
#include "ash/shelf/shelf_view.h"
#include "ash/shell.h"
#include "ash/test/launcher_test_api.h"
@@ -268,11 +268,7 @@ class LauncherAppBrowserTest : public ExtensionBrowserTest {
// Get the index of an item which has the given type.
int GetIndexOfLauncherItemType(ash::LauncherItemType type) {
- for (int i = 0; i < model_->item_count(); i++) {
- if (model_->items()[i].type == type)
- return i;
- }
- return -1;
+ return ash::GetLauncherItemIndexForType(type, *model_);
}
// Try to rip off |item_index|.
@@ -1030,7 +1026,7 @@ IN_PROC_BROWSER_TEST_F(LauncherAppBrowserTest, Navigation) {
IN_PROC_BROWSER_TEST_F(LauncherAppBrowserTest, TabDragAndDrop) {
TabStripModel* tab_strip_model1 = browser()->tab_strip_model();
EXPECT_EQ(1, tab_strip_model1->count());
- int browser_index = ash::GetBrowserItemIndex(*model_);
+ int browser_index = GetIndexOfLauncherItemType(ash::TYPE_BROWSER_SHORTCUT);
EXPECT_TRUE(browser_index >= 0);
EXPECT_EQ(1u, chrome::GetTotalBrowserCount());
@@ -1173,7 +1169,7 @@ IN_PROC_BROWSER_TEST_F(LauncherAppBrowserTest, RefocusFilterLaunch) {
IN_PROC_BROWSER_TEST_F(LauncherAppBrowserTest, ActivationStateCheck) {
TabStripModel* tab_strip = browser()->tab_strip_model();
// Get the browser item index
- int browser_index = ash::GetBrowserItemIndex(*controller_->model());
+ int browser_index = GetIndexOfLauncherItemType(ash::TYPE_BROWSER_SHORTCUT);
EXPECT_TRUE(browser_index >= 0);
// Even though we are just comming up, the browser should be active.
@@ -1835,7 +1831,7 @@ IN_PROC_BROWSER_TEST_F(LauncherAppBrowserTest, MatchingLauncherIDandActiveTab) {
aura::Window* window = browser()->window()->GetNativeWindow();
- int browser_index = ash::GetBrowserItemIndex(*model_);
+ int browser_index = GetIndexOfLauncherItemType(ash::TYPE_BROWSER_SHORTCUT);
ash::LauncherID browser_id = model_->items()[browser_index].id;
EXPECT_EQ(browser_id, controller_->GetIDByWindow(window));
« no previous file with comments | « chrome/browser/ui/ash/launcher/chrome_launcher_controller.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698