Change GetBrowserItemIndex() to GetLauncherItemIndexForType()

ash/shelf/shelf_util.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ash/shelf/shelf_util.h"
 
 #include "ash/launcher/launcher_model.h"
-#include "ash/launcher/launcher_types.h"
 
 namespace ash {
 
-int GetBrowserItemIndex(const LauncherModel& launcher_model) {
+int GetLauncherItemIndexForType(LauncherItemType type,
+                                const LauncherModel& launcher_model) {
+  DCHECK(type == TYPE_BROWSER_SHORTCUT || type == TYPE_APP_LIST);

[sky, 2013/10/22 20:05:17]

Why does the type need to be one of these?

[simonhong_, 2013/10/22 20:22:35]

Because other types can have many items.
Do we need to handle other types, too?
If so, we can return an index of first item in the model.

   for (size_t i = 0; i < launcher_model.items().size(); i++) {
-    if (launcher_model.items()[i].type == ash::TYPE_BROWSER_SHORTCUT)
+    if (launcher_model.items()[i].type == type)
       return i;
   }
   return -1;
 }
 
 }  // namespace ash