Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(470)

Unified Diff: ios/chrome/browser/ui/reading_list/reading_list_empty_collection_background.mm

Issue 2736893002: Display menu icon in iPhone X+ in landscape (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ios/chrome/browser/ui/reading_list/reading_list_empty_collection_background.mm
diff --git a/ios/chrome/browser/ui/reading_list/reading_list_empty_collection_background.mm b/ios/chrome/browser/ui/reading_list/reading_list_empty_collection_background.mm
index 360521e98e75a5537ced87ed451e43faffea14af..d3eaca49850a645debf07dfd71e62ae10f07f79a 100644
--- a/ios/chrome/browser/ui/reading_list/reading_list_empty_collection_background.mm
+++ b/ios/chrome/browser/ui/reading_list/reading_list_empty_collection_background.mm
@@ -108,7 +108,9 @@ const CGFloat kPercentageFromTopForPosition = 0.4;
NSString* accessibilityInstructionString = @":";
// Add the images inside the string.
- if (IsCompact()) {
+ if (IsCompact() || !IsIPadIdiom()) {
+ // TODO(crbug.com/698726): When the share icon is displayed in the toolbar
+ // for landscape iPhone 6+, remove !IsIPadIdiom().
// If the device has a compact display the share menu is accessed from the
// toolbar menu. If it is expanded, the share menu is directly accessible.
[self attachIconNamed:kToolbarMenuIcon
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698