Test that no crash happens with the CWS error page.

chrome/browser/extensions/process_management_browsertest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <stddef.h>
 
 #include "base/strings/utf_string_conversions.h"
 #include "build/build_config.h"
 #include "chrome/browser/extensions/extension_apitest.h"
 #include "chrome/browser/extensions/extension_service.h"
 #include "chrome/browser/profiles/profile.h"
 #include "chrome/browser/profiles/profile_manager.h"
 #include "chrome/browser/ui/browser.h"
 #include "chrome/browser/ui/tabs/tab_strip_model.h"
 #include "chrome/common/chrome_switches.h"
 #include "chrome/common/extensions/extension_process_policy.h"
 #include "chrome/common/url_constants.h"
 #include "chrome/test/base/ui_test_utils.h"
 #include "content/public/browser/render_frame_host.h"
 #include "content/public/browser/render_process_host.h"
 #include "content/public/browser/render_view_host.h"
 #include "content/public/browser/site_instance.h"
 #include "content/public/browser/web_contents.h"
 #include "content/public/test/browser_test_utils.h"
 #include "content/public/test/test_navigation_observer.h"
 #include "extensions/browser/extension_host.h"
 #include "extensions/browser/process_manager.h"
 #include "extensions/browser/process_map.h"
+#include "extensions/common/extension_urls.h"
 #include "extensions/common/switches.h"
 #include "net/dns/mock_host_resolver.h"
 #include "net/test/embedded_test_server/embedded_test_server.h"
 
 using content::NavigationController;
 using content::WebContents;
 
 namespace {
 
 class ProcessManagementTest : public ExtensionBrowserTest {
@@ skipping 344 matching lines @@
   // Verify that we really have the Chrome Web Store app loaded in the Web
   // Contents.
   content::RenderProcessHost* new_process_host =
       web_contents->GetMainFrame()->GetProcess();
   EXPECT_TRUE(extensions::ProcessMap::Get(profile())->Contains(
       extensions::kWebStoreAppId, new_process_host->GetID()));
 
   // Verify that Chrome Web Store is isolated in a separate renderer process.
   EXPECT_NE(old_process_host, new_process_host);
 }
+
+// This problem is similar to https://crbug.com/622385. It happens when an
+// iframe error page with the Chrome Web Store URL is displayed and the iframe
+// and its parent reside in the same process. In this case, the renderer
+// process is killed with the RFH_CAN_COMMIT_URL_BLOCKED error code. This test
+// asserts that the renderer is still alive after the navigation.

[nasko, 2017/03/09 17:18:11]

nit: "renderer process". One of the main goals I have when reviewing comments is
for them to be very explicit and precise. Just using the word "renderer" makes
is ambiguous - is it the process or the RenderFrame? Let's try to never use just
the word "renderer" by itself, but be more precise.

[arthursonzogni, 2017/03/10 09:25:47]

Done.

+IN_PROC_BROWSER_TEST_F(ChromeWebStoreProcessTest,
+                       ChromeWebStoreBlockedByFrameSrc) {
+  GURL url =
+      embedded_test_server()->GetURL("/extensions/iframe-child-src-none.html");
+  ui_test_utils::NavigateToURL(browser(), url);
+
+  WebContents* web_contents =
+      browser()->tab_strip_model()->GetActiveWebContents();
+
+  // Make the iframe navigate to the Chrome Web Store and wait for the 'load'
+  // event. This is also a check that the renderer is still alive after the
+  // navigation.
+  std::string message;
+  EXPECT_TRUE(ExecuteScriptAndExtractString(
+      web_contents,
+      "var iframe = document.getElementById('test'); iframe.onload = "

[nasko, 2017/03/09 17:18:11]

nit: I'd put the iframe.onload on the new line and combine it with the
"function() {" part. It makes it more clear that we are assigning a function to
the onload event handler.

[arthursonzogni, 2017/03/10 09:25:47]

Done.

+      "function() { domAutomationController.send('iframe loaded'); }; "
+      "iframe.src = '" +
+          std::string(extension_urls::kChromeWebstoreBaseURL) + "';",
+      &message));

[nasko, 2017/03/09 17:18:11]

Doesn't ExecuteScriptAndExtractString basically return after executing the
statement in its argument? How does it wait if the load would take long time?

[arthursonzogni, 2017/03/10 09:25:47]

It is waiting that the domAutomationController send something.
It calls DOMMessageQueue::WaitForMessage(...)

So, it will wait as long as it takes.

+  EXPECT_EQ("iframe loaded", message);
+}