third_party/WebKit/Source/core/html/shadow/MediaControlsMediaEventListener.h - Issue 2736853003: Media: fix memory leak because of the document holding on an EventListener.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/html/shadow/MediaControlsMediaEventListener.h

Issue 2736853003: Media: fix memory leak because of the document holding on an EventListener. (Closed)

Patch Set: Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/html/shadow/MediaControlsLeakTest.cpp ('k') | third_party/WebKit/Source/core/html/shadow/MediaControlsMediaEventListener.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/html/shadow/MediaControlsMediaEventListener.h

diff --git a/third_party/WebKit/Source/core/html/shadow/MediaControlsMediaEventListener.h b/third_party/WebKit/Source/core/html/shadow/MediaControlsMediaEventListener.h

index cd88cb44e0ed098afd5ae863da541460cb305169..a653202928a911fbff9c5a360805abacc5d87727 100644

--- a/third_party/WebKit/Source/core/html/shadow/MediaControlsMediaEventListener.h

+++ b/third_party/WebKit/Source/core/html/shadow/MediaControlsMediaEventListener.h

@@ -16,6 +16,15 @@ class MediaControlsMediaEventListener final : public EventListener {

public:

explicit MediaControlsMediaEventListener(MediaControls*);

+ // Called by MediaControls when the HTMLMediaElement is added to a document

+ // document. All event listeners should be added.

+ void attach();

+ // Called by MediaControls when the HTMLMediaElement is no longer in the

+ // document. All event listeners should be removed in order to prepare the

+ // object to be garbage collected.

+ void detach();

bool operator==(const EventListener&) const override;

DECLARE_VIRTUAL_TRACE();