third_party/WebKit/Source/devtools/front_end/sources/OpenResourceDialog.js - Issue 2736853002: DevTools: Convert FilteredListWidget to use an optional provider

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/sources/OpenResourceDialog.js

Issue 2736853002: DevTools: Convert FilteredListWidget to use an optional provider (Closed)

Patch Set: missing timeout Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/devtools/front_end/sources/JavaScriptOutlineDialog.js ('k') | third_party/WebKit/Source/devtools/front_end/sources/StyleSheetOutlineDialog.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/devtools/front_end/sources/OpenResourceDialog.js

diff --git a/third_party/WebKit/Source/devtools/front_end/sources/OpenResourceDialog.js b/third_party/WebKit/Source/devtools/front_end/sources/OpenResourceDialog.js

index e6bb0f3eb80ef6a562203a39a75321e64560c22f..3a32f4ed97587b9d31fb49d4c820338eb0f7bf41 100644

--- a/third_party/WebKit/Source/devtools/front_end/sources/OpenResourceDialog.js

+++ b/third_party/WebKit/Source/devtools/front_end/sources/OpenResourceDialog.js

@@ -7,7 +7,7 @@

/**

* @unrestricted

-Sources.OpenResourceDialog = class extends Sources.FilteredUISourceCodeListDelegate {

+Sources.OpenResourceDialog = class extends Sources.FilteredUISourceCodeListProvider {

/**

* @param {!Sources.SourcesView} sourcesView

* @param {!Map.<!Workspace.UISourceCode, number>} defaultScores

@@ -15,7 +15,6 @@ Sources.OpenResourceDialog = class extends Sources.FilteredUISourceCodeListDeleg

constructor(sourcesView, defaultScores) {

super(defaultScores);

this._sourcesView = sourcesView;

- this.populate();

}

/**

@@ -80,7 +79,7 @@ Sources.OpenResourceDialog = class extends Sources.FilteredUISourceCodeListDeleg

/**

* @unrestricted

-Sources.SelectUISourceCodeForProjectTypesDialog = class extends Sources.FilteredUISourceCodeListDelegate {

+Sources.SelectUISourceCodeForProjectTypesDialog = class extends Sources.FilteredUISourceCodeListProvider {

/**

* @param {!Array.<string>} types

* @param {function(?Workspace.UISourceCode)} callback

@@ -89,7 +88,6 @@ Sources.SelectUISourceCodeForProjectTypesDialog = class extends Sources.Filtered

super();

this._types = types;

this._callback = callback;

- this.populate();

}

/**