Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(367)

Unified Diff: third_party/WebKit/Source/devtools/front_end/sources/FilteredUISourceCodeListProvider.js

Issue 2736853002: DevTools: Convert FilteredListWidget to use an optional provider (Closed)
Patch Set: missing timeout Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/devtools/front_end/sources/FilteredUISourceCodeListProvider.js
diff --git a/third_party/WebKit/Source/devtools/front_end/sources/FilteredUISourceCodeListDelegate.js b/third_party/WebKit/Source/devtools/front_end/sources/FilteredUISourceCodeListProvider.js
similarity index 96%
rename from third_party/WebKit/Source/devtools/front_end/sources/FilteredUISourceCodeListDelegate.js
rename to third_party/WebKit/Source/devtools/front_end/sources/FilteredUISourceCodeListProvider.js
index c8f94740cebe38021cd7b2f293fa904d3ffeb84a..038e8d8a461334d71f13ba90aaec2f4e0c49c20d 100644
--- a/third_party/WebKit/Source/devtools/front_end/sources/FilteredUISourceCodeListDelegate.js
+++ b/third_party/WebKit/Source/devtools/front_end/sources/FilteredUISourceCodeListProvider.js
@@ -7,7 +7,7 @@
/**
* @unrestricted
*/
-Sources.FilteredUISourceCodeListDelegate = class extends QuickOpen.FilteredListWidget.Delegate {
+Sources.FilteredUISourceCodeListProvider = class extends QuickOpen.FilteredListWidget.Provider {
/**
* @param {!Map.<!Workspace.UISourceCode, number>=} defaultScores
*/
@@ -16,8 +16,6 @@ Sources.FilteredUISourceCodeListDelegate = class extends QuickOpen.FilteredListW
this._defaultScores = defaultScores;
this._scorer = new Sources.FilePathScoreFunction('');
- Workspace.workspace.addEventListener(Workspace.Workspace.Events.UISourceCodeAdded, this._uiSourceCodeAdded, this);
- Workspace.workspace.addEventListener(Workspace.Workspace.Events.ProjectRemoved, this._projectRemoved, this);
}
/**
@@ -25,15 +23,14 @@ Sources.FilteredUISourceCodeListDelegate = class extends QuickOpen.FilteredListW
*/
_projectRemoved(event) {
var project = /** @type {!Workspace.Project} */ (event.data);
- this.populate(project);
+ this._populate(project);
this.refresh();
}
/**
- * @protected
* @param {!Workspace.Project=} skipProject
*/
- populate(skipProject) {
+ _populate(skipProject) {
/** @type {!Array.<!Workspace.UISourceCode>} */
this._uiSourceCodes = [];
var projects = Workspace.workspace.projects().filter(this.filterProject.bind(this));
@@ -213,7 +210,16 @@ Sources.FilteredUISourceCodeListDelegate = class extends QuickOpen.FilteredListW
/**
* @override
*/
- dispose() {
+ attach() {
+ Workspace.workspace.addEventListener(Workspace.Workspace.Events.UISourceCodeAdded, this._uiSourceCodeAdded, this);
+ Workspace.workspace.addEventListener(Workspace.Workspace.Events.ProjectRemoved, this._projectRemoved, this);
+ this._populate();
+ }
+
+ /**
+ * @override
+ */
+ detach() {
Workspace.workspace.removeEventListener(
Workspace.Workspace.Events.UISourceCodeAdded, this._uiSourceCodeAdded, this);
Workspace.workspace.removeEventListener(Workspace.Workspace.Events.ProjectRemoved, this._projectRemoved, this);

Powered by Google App Engine
This is Rietveld 408576698