third_party/WebKit/LayoutTests/inspector/filtered-item-selection-dialog-rendering.html - Issue 2736853002: DevTools: Convert FilteredListWidget to use an optional provider

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/LayoutTests/inspector/filtered-item-selection-dialog-rendering.html

Issue 2736853002: DevTools: Convert FilteredListWidget to use an optional provider (Closed)

Patch Set: missing timeout Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/http/tests/inspector-unit/filtered-list-widget-providers-expected.txt ('k') | third_party/WebKit/Source/devtools/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/inspector/filtered-item-selection-dialog-rendering.html

diff --git a/third_party/WebKit/LayoutTests/inspector/filtered-item-selection-dialog-rendering.html b/third_party/WebKit/LayoutTests/inspector/filtered-item-selection-dialog-rendering.html

index fe82b19bf8aff6bcf97be0dec6299c3105011c72..47e413ede7a5db0de563e5739115165b3fba9026 100644

--- a/third_party/WebKit/LayoutTests/inspector/filtered-item-selection-dialog-rendering.html

+++ b/third_party/WebKit/LayoutTests/inspector/filtered-item-selection-dialog-rendering.html

@@ -11,8 +11,8 @@

function test()

{

- var delegate = new Sources.FilteredUISourceCodeListDelegate();

- delegate.populate();

+ var provider = new Sources.FilteredUISourceCodeListProvider();

+ provider.attach();

InspectorTest.runTestSuite([

function testRenderingInNameOnly(next)

@@ -46,8 +46,8 @@ function test()

var titleElement = document.createElement("div");

var subtitleElement = document.createElement("div");

var outputs = [];

- for (var i = 0; i < delegate.itemCount(); ++i) {

- delegate.renderItem(i, query, titleElement, subtitleElement);

+ for (var i = 0; i < provider.itemCount(); ++i) {

+ provider.renderItem(i, query, titleElement, subtitleElement);

if (!subtitleElement.textContent.startsWith("test"))

continue;

var text = elementHighlightedText(titleElement);