Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1434)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/download/DownloadItem.java

Issue 2736843002: Fix the Download Notifications for Offline Pages to indicate bytes loaded. (Closed)
Patch Set: fix typo Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/download/DownloadItem.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/download/DownloadItem.java b/chrome/android/java/src/org/chromium/chrome/browser/download/DownloadItem.java
index 13db5a41207809d491137ddc253ec8844304c40b..9d0d94da18e13913b7b8e78e65abc594982c343f 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/download/DownloadItem.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/download/DownloadItem.java
@@ -14,8 +14,10 @@ import org.chromium.base.annotations.CalledByNative;
* DownloadManager must be queried for the correct status.
*/
public class DownloadItem {
+ // Used to indicate 'indeterminate' progress, this is usually visualized in UI as a different
+ // style of progress bar and also removes the "nn%" indicators.
+ public static final int INVALID_DOWNLOAD_PERCENTAGE = -1;
fgorski 2017/03/07 22:26:43 Is there any other condition causing invalid? why
Dmitry Titov 2017/03/08 00:47:38 Renamed, hope Min concurs.
static final long INVALID_DOWNLOAD_ID = -1L;
- static final int INVALID_DOWNLOAD_PERCENTAGE = -1;
private boolean mUseAndroidDownloadManager;
private DownloadInfo mDownloadInfo;

Powered by Google App Engine
This is Rietveld 408576698