components/offline_pages/core/downloads/download_notifying_observer.h - Issue 2736843002: Fix the Download Notifications for Offline Pages to indicate bytes loaded.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/offline_pages/core/downloads/download_notifying_observer.h

Issue 2736843002: Fix the Download Notifications for Offline Pages to indicate bytes loaded. (Closed)

Patch Set: more fixes to more tests. Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/offline_pages/core/background/request_queue_unittest.cc ('k') | components/offline_pages/core/downloads/download_notifying_observer.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/offline_pages/core/downloads/download_notifying_observer.h

diff --git a/components/offline_pages/core/downloads/download_notifying_observer.h b/components/offline_pages/core/downloads/download_notifying_observer.h

index 6980102b47f32b6d4b7bb1980a701afcc8c2984f..cf860427a6804695778bc29f20ee94df3f4581a9 100644

--- a/components/offline_pages/core/downloads/download_notifying_observer.h

+++ b/components/offline_pages/core/downloads/download_notifying_observer.h

@@ -11,6 +11,7 @@

#include "base/macros.h"

#include "components/offline_pages/core/background/request_coordinator.h"

#include "components/offline_pages/core/client_policy_controller.h"

+#include "components/offline_pages/core/downloads/download_ui_item.h"

namespace offline_pages {

@@ -38,6 +39,8 @@ class DownloadNotifyingObserver : public RequestCoordinator::Observer,

void OnCompleted(

const SavePageRequest& request,

RequestCoordinator::BackgroundSavePageResult status) override;

+ void OnNetworkProgress(const SavePageRequest& request,

+ int64_t received_bytes) override;

private:

friend class DownloadNotifyingObserverTest;