Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(124)

Unified Diff: components/offline_pages/core/background/request_coordinator_unittest.cc

Issue 2736843002: Fix the Download Notifications for Offline Pages to indicate bytes loaded. (Closed)
Patch Set: more fixes to more tests. Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/offline_pages/core/background/request_coordinator_unittest.cc
diff --git a/components/offline_pages/core/background/request_coordinator_unittest.cc b/components/offline_pages/core/background/request_coordinator_unittest.cc
index 753dd8831ec926611a310b79210d4a23f228c117..0850befe39ce06f99f703aec49c0e531a5b05ddf 100644
--- a/components/offline_pages/core/background/request_coordinator_unittest.cc
+++ b/components/offline_pages/core/background/request_coordinator_unittest.cc
@@ -60,6 +60,8 @@ class ObserverStub : public RequestCoordinator::Observer {
: added_called_(false),
completed_called_(false),
changed_called_(false),
+ network_progress_called_(false),
+ network_progress_bytes_(0),
last_status_(RequestCoordinator::BackgroundSavePageResult::SUCCESS),
state_(SavePageRequest::RequestState::OFFLINING) {}
@@ -67,6 +69,8 @@ class ObserverStub : public RequestCoordinator::Observer {
added_called_ = false;
completed_called_ = false;
changed_called_ = false;
+ network_progress_called_ = false;
+ network_progress_bytes_ = 0;
state_ = SavePageRequest::RequestState::OFFLINING;
last_status_ = RequestCoordinator::BackgroundSavePageResult::SUCCESS;
}
@@ -87,9 +91,17 @@ class ObserverStub : public RequestCoordinator::Observer {
state_ = request.request_state();
}
+ void OnNetworkProgress(const SavePageRequest& request,
+ int64_t received_bytes) override {
+ network_progress_called_ = true;
+ network_progress_bytes_ = received_bytes;
+ }
+
bool added_called() { return added_called_; }
bool completed_called() { return completed_called_; }
bool changed_called() { return changed_called_; }
+ bool network_progress_called() { return network_progress_called_; }
+ int64_t network_progress_bytes() { return network_progress_bytes_; }
RequestCoordinator::BackgroundSavePageResult last_status() {
return last_status_;
}
@@ -99,6 +111,8 @@ class ObserverStub : public RequestCoordinator::Observer {
bool added_called_;
bool completed_called_;
bool changed_called_;
+ bool network_progress_called_;
+ int64_t network_progress_bytes_;
RequestCoordinator::BackgroundSavePageResult last_status_;
SavePageRequest::RequestState state_;
};
@@ -455,6 +469,13 @@ TEST_F(RequestCoordinatorTest, StartScheduledProcessingWithNoRequests) {
}
}
+TEST_F(RequestCoordinatorTest, NetworkProgressCallback) {
+ EXPECT_NE(0, SavePageLater());
+ PumpLoop();
+ EXPECT_TRUE(observer().network_progress_called());
+ EXPECT_GT(observer().network_progress_bytes(), 0LL);
+}
+
TEST_F(RequestCoordinatorTest, StartScheduledProcessingWithRequestInProgress) {
// Start processing for this request.
EXPECT_NE(0, SavePageLater());

Powered by Google App Engine
This is Rietveld 408576698