Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(176)

Unified Diff: chrome/browser/android/offline_pages/background_loader_offliner.cc

Issue 2736843002: Fix the Download Notifications for Offline Pages to indicate bytes loaded. (Closed)
Patch Set: more fixes to more tests. Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/android/offline_pages/background_loader_offliner.cc
diff --git a/chrome/browser/android/offline_pages/background_loader_offliner.cc b/chrome/browser/android/offline_pages/background_loader_offliner.cc
index bfc55e3c0451feadcd033ab282e089529ce308f9..14306ff6986698821acd91712e42d5c0930fe831 100644
--- a/chrome/browser/android/offline_pages/background_loader_offliner.cc
+++ b/chrome/browser/android/offline_pages/background_loader_offliner.cc
@@ -39,9 +39,13 @@ BackgroundLoaderOffliner::BackgroundLoaderOffliner(
BackgroundLoaderOffliner::~BackgroundLoaderOffliner() {}
-bool BackgroundLoaderOffliner::LoadAndSave(const SavePageRequest& request,
- const CompletionCallback& callback) {
- DCHECK(callback);
+// TODO(dimich): Invoke progress_callback as appropriate.
+bool BackgroundLoaderOffliner::LoadAndSave(
+ const SavePageRequest& request,
+ const CompletionCallback& completion_callback,
+ const ProgressCallback& progress_callback) {
+ DCHECK(completion_callback);
+ DCHECK(progress_callback);
if (pending_request_) {
DVLOG(1) << "Already have pending request";
@@ -104,7 +108,7 @@ bool BackgroundLoaderOffliner::LoadAndSave(const SavePageRequest& request,
// Track copy of pending request.
pending_request_.reset(new SavePageRequest(request));
- completion_callback_ = callback;
+ completion_callback_ = completion_callback;
// Listen for app foreground/background change.
app_listener_.reset(new base::android::ApplicationStatusListener(

Powered by Google App Engine
This is Rietveld 408576698