Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(324)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/download/DownloadItem.java

Issue 2736843002: Fix the Download Notifications for Offline Pages to indicate bytes loaded. (Closed)
Patch Set: more fixes to more tests. Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/android/java/src/org/chromium/chrome/browser/download/DownloadNotificationService.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/android/java/src/org/chromium/chrome/browser/download/DownloadItem.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/download/DownloadItem.java b/chrome/android/java/src/org/chromium/chrome/browser/download/DownloadItem.java
index 13db5a41207809d491137ddc253ec8844304c40b..7c98a936264607b5c3e4c7a041786519db25a3fd 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/download/DownloadItem.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/download/DownloadItem.java
@@ -14,8 +14,8 @@ import org.chromium.base.annotations.CalledByNative;
* DownloadManager must be queried for the correct status.
*/
public class DownloadItem {
+ public static final int INDETERMINATE_DOWNLOAD_PERCENTAGE = -1;
static final long INVALID_DOWNLOAD_ID = -1L;
- static final int INVALID_DOWNLOAD_PERCENTAGE = -1;
private boolean mUseAndroidDownloadManager;
private DownloadInfo mDownloadInfo;
@@ -128,6 +128,6 @@ public class DownloadItem {
* @return Whether or not the download has an indeterminate percentage.
*/
public boolean isIndeterminate() {
- return getDownloadInfo().getPercentCompleted() == INVALID_DOWNLOAD_PERCENTAGE;
+ return getDownloadInfo().getPercentCompleted() == INDETERMINATE_DOWNLOAD_PERCENTAGE;
}
}
« no previous file with comments | « no previous file | chrome/android/java/src/org/chromium/chrome/browser/download/DownloadNotificationService.java » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698