components/offline_pages/core/background/request_notifier.h - Issue 2736843002: Fix the Download Notifications for Offline Pages to indicate bytes loaded.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: components/offline_pages/core/background/request_notifier.h

Issue 2736843002: Fix the Download Notifications for Offline Pages to indicate bytes loaded. (Closed)

Patch Set: fix typo Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« chrome/browser/android/offline_pages/prerendering_offliner.cc ('K') | « components/offline_pages/core/background/request_coordinator.cc ('k') | components/offline_pages/core/background/request_queue_unittest.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 // Copyright 2016 The Chromium Authors. All rights reserved.	1 // Copyright 2016 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #ifndef COMPONENTS_OFFLINE_PAGES_CORE_BACKGROUND_REQUEST_NOTIFIER_H_	5 #ifndef COMPONENTS_OFFLINE_PAGES_CORE_BACKGROUND_REQUEST_NOTIFIER_H_

6 #define COMPONENTS_OFFLINE_PAGES_CORE_BACKGROUND_REQUEST_NOTIFIER_H_	6 #define COMPONENTS_OFFLINE_PAGES_CORE_BACKGROUND_REQUEST_NOTIFIER_H_

7	7

8 namespace offline_pages {	8 namespace offline_pages {

9	9

10 class SavePageRequest;	10 class SavePageRequest;

(...skipping 20 matching lines...) Expand all Loading...
31	31

32 // Notifies observers that \|request\| has been added.	32 // Notifies observers that \|request\| has been added.

33 virtual void NotifyAdded(const SavePageRequest& request) = 0;	33 virtual void NotifyAdded(const SavePageRequest& request) = 0;

34	34

35 // Notifies observers that \|request\| has been completed with \|status\|.	35 // Notifies observers that \|request\| has been completed with \|status\|.

36 virtual void NotifyCompleted(const SavePageRequest& request,	36 virtual void NotifyCompleted(const SavePageRequest& request,

37 BackgroundSavePageResult status) = 0;	37 BackgroundSavePageResult status) = 0;

38	38

39 // Notifies observers that \|request\| has been changed.	39 // Notifies observers that \|request\| has been changed.

40 virtual void NotifyChanged(const SavePageRequest& request) = 0;	40 virtual void NotifyChanged(const SavePageRequest& request) = 0;

	41
	fgorski 2017/03/07 22:26:43 Nit: // Notifies observers of progress on \|request Nit: // Notifies observers of progress on \|request\|, which received \|received_bytes\| at that point. Dmitry Titov 2017/03/08 00:47:38 Done. Show quoted text On 2017/03/07 22:26:43, fgorski wrote: > Nit: // Notifies observers of progress on \|request\|, which received > \|received_bytes\| at that point. Done.
	42 virtual void NotifyNetworkProgress(const SavePageRequest& request,

	43 int64_t received_bytes) = 0;

41 };	44 };

42	45

43 } // namespace offline_pages	46 } // namespace offline_pages

44	47

45 #endif // COMPONENTS_OFFLINE_PAGES_CORE_BACKGROUND_REQUEST_NOTIFIER_H_	48 #endif // COMPONENTS_OFFLINE_PAGES_CORE_BACKGROUND_REQUEST_NOTIFIER_H_

OLD	NEW