Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(59)

Side by Side Diff: components/offline_pages/core/background/request_queue_unittest.cc

Issue 2736843002: Fix the Download Notifications for Offline Pages to indicate bytes loaded. (Closed)
Patch Set: more fixes to more tests. Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "components/offline_pages/core/background/request_queue.h" 5 #include "components/offline_pages/core/background/request_queue.h"
6 6
7 #include <memory> 7 #include <memory>
8 #include <utility> 8 #include <utility>
9 9
10 #include "base/bind.h" 10 #include "base/bind.h"
(...skipping 45 matching lines...) Expand 10 before | Expand all | Expand 10 after
56 void NotifyAdded(const SavePageRequest& request) override {} 56 void NotifyAdded(const SavePageRequest& request) override {}
57 void NotifyChanged(const SavePageRequest& request) override {} 57 void NotifyChanged(const SavePageRequest& request) override {}
58 58
59 void NotifyCompleted(const SavePageRequest& request, 59 void NotifyCompleted(const SavePageRequest& request,
60 BackgroundSavePageResult status) override { 60 BackgroundSavePageResult status) override {
61 last_expired_request_ = request; 61 last_expired_request_ = request;
62 last_request_expiration_status_ = status; 62 last_request_expiration_status_ = status;
63 total_expired_requests_++; 63 total_expired_requests_++;
64 } 64 }
65 65
66 void NotifyNetworkProgress(const SavePageRequest& request,
67 int64_t received_bytes) override {
68 // This has nothing to do with the queue (progress is ephemeral) - no test.
69 }
70
66 const SavePageRequest& last_expired_request() { 71 const SavePageRequest& last_expired_request() {
67 return last_expired_request_; 72 return last_expired_request_;
68 } 73 }
69 74
70 RequestCoordinator::BackgroundSavePageResult 75 RequestCoordinator::BackgroundSavePageResult
71 last_request_expiration_status() { 76 last_request_expiration_status() {
72 return last_request_expiration_status_; 77 return last_request_expiration_status_;
73 } 78 }
74 79
75 int32_t total_expired_requests() { return total_expired_requests_; } 80 int32_t total_expired_requests() { return total_expired_requests_; }
(...skipping 493 matching lines...) Expand 10 before | Expand all | Expand 10 after
569 // Doing a get should show no entries left in the queue since the expired 574 // Doing a get should show no entries left in the queue since the expired
570 // request has been removed. 575 // request has been removed.
571 queue()->GetRequests( 576 queue()->GetRequests(
572 base::Bind(&RequestQueueTest::GetRequestsDone, base::Unretained(this))); 577 base::Bind(&RequestQueueTest::GetRequestsDone, base::Unretained(this)));
573 this->PumpLoop(); 578 this->PumpLoop();
574 ASSERT_EQ(GetRequestsResult::SUCCESS, this->last_get_requests_result()); 579 ASSERT_EQ(GetRequestsResult::SUCCESS, this->last_get_requests_result());
575 ASSERT_TRUE(this->last_requests().empty()); 580 ASSERT_TRUE(this->last_requests().empty());
576 } 581 }
577 582
578 } // namespace offline_pages 583 } // namespace offline_pages
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698