Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(682)

Side by Side Diff: components/offline_pages/core/background/cleanup_task_unittest.cc

Issue 2736843002: Fix the Download Notifications for Offline Pages to indicate bytes loaded. (Closed)
Patch Set: more fixes to more tests. Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "components/offline_pages/core/background/cleanup_task.h" 5 #include "components/offline_pages/core/background/cleanup_task.h"
6 6
7 #include <memory> 7 #include <memory>
8 #include <set> 8 #include <set>
9 9
10 #include "base/bind.h" 10 #include "base/bind.h"
(...skipping 40 matching lines...) Expand 10 before | Expand all | Expand 10 after
51 void NotifyAdded(const SavePageRequest& request) override {} 51 void NotifyAdded(const SavePageRequest& request) override {}
52 void NotifyChanged(const SavePageRequest& request) override {} 52 void NotifyChanged(const SavePageRequest& request) override {}
53 53
54 void NotifyCompleted(const SavePageRequest& request, 54 void NotifyCompleted(const SavePageRequest& request,
55 BackgroundSavePageResult status) override { 55 BackgroundSavePageResult status) override {
56 last_expired_request_ = request; 56 last_expired_request_ = request;
57 last_request_expiration_status_ = status; 57 last_request_expiration_status_ = status;
58 total_expired_requests_++; 58 total_expired_requests_++;
59 } 59 }
60 60
61 void NotifyNetworkProgress(const SavePageRequest& request,
62 int64_t received_bytes) override {}
63
61 const SavePageRequest& last_expired_request() { 64 const SavePageRequest& last_expired_request() {
62 return last_expired_request_; 65 return last_expired_request_;
63 } 66 }
64 67
65 RequestCoordinator::BackgroundSavePageResult 68 RequestCoordinator::BackgroundSavePageResult
66 last_request_expiration_status() { 69 last_request_expiration_status() {
67 return last_request_expiration_status_; 70 return last_request_expiration_status_;
68 } 71 }
69 72
70 int32_t total_expired_requests() { return total_expired_requests_; } 73 int32_t total_expired_requests() { return total_expired_requests_; }
(...skipping 199 matching lines...) Expand 10 before | Expand all | Expand 10 after
270 // though it is expired because it was listed as in-progress while cleaning. 273 // though it is expired because it was listed as in-progress while cleaning.
271 // Request2 should have been cleaned out of the queue. 274 // Request2 should have been cleaned out of the queue.
272 store()->GetRequests(base::Bind(&CleanupTaskTest::GetRequestsCallback, 275 store()->GetRequests(base::Bind(&CleanupTaskTest::GetRequestsCallback,
273 base::Unretained(this))); 276 base::Unretained(this)));
274 PumpLoop(); 277 PumpLoop();
275 EXPECT_EQ(1UL, found_requests().size()); 278 EXPECT_EQ(1UL, found_requests().size());
276 EXPECT_EQ(kRequestId1, found_requests().at(0)->request_id()); 279 EXPECT_EQ(kRequestId1, found_requests().at(0)->request_id());
277 } 280 }
278 281
279 } // namespace offline_pages 282 } // namespace offline_pages
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698