Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1312)

Unified Diff: Source/modules/serviceworkers/InstallEvent.cpp

Issue 273683006: ScriptPromise should understand the ScriptState from which the ScriptPromise is generated (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/modules/serviceworkers/InstallEvent.h ('k') | Source/modules/serviceworkers/InstallEvent.idl » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/modules/serviceworkers/InstallEvent.cpp
diff --git a/Source/modules/serviceworkers/InstallEvent.cpp b/Source/modules/serviceworkers/InstallEvent.cpp
index ceb35235ebbd312b1e5308f1ebcfb442ae3680c9..d0942e1e19cac0d643418340419432a234e9e680 100644
--- a/Source/modules/serviceworkers/InstallEvent.cpp
+++ b/Source/modules/serviceworkers/InstallEvent.cpp
@@ -54,15 +54,15 @@ void InstallEvent::replace()
notImplemented();
}
-ScriptPromise InstallEvent::reloadAll(ExecutionContext* context)
+ScriptPromise InstallEvent::reloadAll(ScriptState* scriptState)
{
// FIXME: implement.
notImplemented();
// For now this just returns a promise which is already rejected.
- RefPtr<ScriptPromiseResolver> resolver = ScriptPromiseResolver::create(context);
+ RefPtr<ScriptPromiseResolver> resolver = ScriptPromiseResolver::create(scriptState);
ScriptPromise promise = resolver->promise();
- resolver->reject(ScriptValue(v8::Null(toIsolate(context)), toIsolate(context)));
+ resolver->reject(ScriptValue(v8::Null(scriptState->isolate()), scriptState->isolate()));
return promise;
}
« no previous file with comments | « Source/modules/serviceworkers/InstallEvent.h ('k') | Source/modules/serviceworkers/InstallEvent.idl » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698