Source/bindings/scripts/v8_types.py - Issue 273683006: ScriptPromise should understand the ScriptState from which the ScriptPromise is generated

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/scripts/v8_types.py

Issue 273683006: ScriptPromise should understand the ScriptState from which the ScriptPromise is generated (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/bindings/scripts/v8_types.py

diff --git a/Source/bindings/scripts/v8_types.py b/Source/bindings/scripts/v8_types.py

index 466ab25e05ffe2237fc380efa6eff1c10e11ae9b..13db5d3c92f35f6bfbf22a2286447895231520dc 100644

--- a/Source/bindings/scripts/v8_types.py

+++ b/Source/bindings/scripts/v8_types.py

@@ -371,7 +371,7 @@ V8_VALUE_TO_CPP_VALUE = {

'EventTarget': 'V8DOMWrapper::isDOMWrapper({v8_value}) ? toWrapperTypeInfo(v8::Handle<v8::Object>::Cast({v8_value}))->toEventTarget(v8::Handle<v8::Object>::Cast({v8_value})) : 0',

'MediaQueryListListener': 'MediaQueryListListener::create(ScriptValue(ScriptState::current(info.GetIsolate()), {v8_value}))',

'NodeFilter': 'toNodeFilter({v8_value}, info.GetIsolate())',

- 'Promise': 'ScriptPromise({v8_value}, info.GetIsolate())',

+ 'Promise': 'ScriptPromise(ScriptState::current(info.GetIsolate()), {v8_value})',

'SerializedScriptValue': 'SerializedScriptValue::create({v8_value}, info.GetIsolate())',

'ScriptValue': 'ScriptValue(ScriptState::current(info.GetIsolate()), {v8_value})',

'Window': 'toDOMWindow({v8_value}, info.GetIsolate())',

« no previous file with comments | « no previous file | Source/bindings/tests/results/V8TestObject.cpp » ('j') | no next file with comments »