ScriptPromise should understand the ScriptState from which the ScriptPromise is generated

Source/bindings/v8/ScriptPromiseTest.cpp

 /*
  * Copyright (C) 2014 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 32 matching lines @@
 
 namespace WebCore {
 
 namespace {
 
 void callback(const v8::FunctionCallbackInfo<v8::Value>& info) { }
 
 class ScriptPromiseTest : public testing::Test {
 public:
     ScriptPromiseTest()
-        : m_isolate(v8::Isolate::GetCurrent())
+        : m_scope(V8ExecutionScope::create(v8::Isolate::GetCurrent()))
     {
-        m_scope = V8ExecutionScope::create(m_isolate);
     }
 
     ~ScriptPromiseTest()
     {
         // FIXME: We put this statement here to clear an exception from the isolate.
-        createClosure(callback, v8::Undefined(m_isolate), m_isolate);
+        createClosure(callback, v8::Undefined(m_scope->isolate()), m_scope->isolate());
     }
 
     V8PromiseCustom::PromiseState state(ScriptPromise promise)
     {
         return V8PromiseCustom::getState(V8PromiseCustom::getInternal(promise.v8Value().As<v8::Object>()));
     }
 
 protected:
-    v8::Isolate* m_isolate;
-
-private:
     OwnPtr<V8ExecutionScope> m_scope;
 };
 
 TEST_F(ScriptPromiseTest, constructFromNonPromise)
 {
     v8::TryCatch trycatch;
-    ScriptPromise promise(v8::Undefined(m_isolate), m_isolate);
+    ScriptPromise promise(m_scope->scriptState(), v8::Undefined(m_scope->isolate()));
     ASSERT_TRUE(trycatch.HasCaught());
     ASSERT_TRUE(promise.isEmpty());
 }
 
 TEST_F(ScriptPromiseTest, castPromise)
 {
     if (RuntimeEnabledFeatures::scriptPromiseOnV8PromiseEnabled())
         return;
-    ScriptPromise promise = ScriptPromiseResolver::create(m_isolate)->promise();
-    ScriptPromise newPromise = ScriptPromise::cast(ScriptValue(ScriptState::current(m_isolate), promise.v8Value()));
+    ScriptPromise promise = ScriptPromiseResolver::create(m_scope->scriptState())->promise();
+    ScriptPromise newPromise = ScriptPromise::cast(ScriptValue(m_scope->scriptState(), promise.v8Value()));
 
     ASSERT_FALSE(promise.isEmpty());
     EXPECT_EQ(V8PromiseCustom::Pending, state(promise));
     EXPECT_EQ(promise.v8Value(), newPromise.v8Value());
 }
 
 TEST_F(ScriptPromiseTest, castNonPromise)
 {
     if (RuntimeEnabledFeatures::scriptPromiseOnV8PromiseEnabled())
         return;
-    ScriptValue value = ScriptValue(ScriptState::current(m_isolate), v8String(m_isolate, "hello"));
+    ScriptValue value = ScriptValue(m_scope->scriptState(), v8String(m_scope->isolate(), "hello"));
     ScriptPromise promise1 = ScriptPromise::cast(ScriptValue(value));
     ScriptPromise promise2 = ScriptPromise::cast(ScriptValue(value));
 
     ASSERT_FALSE(promise1.isEmpty());
     ASSERT_FALSE(promise2.isEmpty());
 
-    ASSERT_TRUE(V8PromiseCustom::isPromise(promise1.v8Value(), m_isolate));
-    ASSERT_TRUE(V8PromiseCustom::isPromise(promise2.v8Value(), m_isolate));
+    ASSERT_TRUE(V8PromiseCustom::isPromise(promise1.v8Value(), m_scope->isolate()));
+    ASSERT_TRUE(V8PromiseCustom::isPromise(promise2.v8Value(), m_scope->isolate()));
 
     EXPECT_EQ(V8PromiseCustom::Fulfilled, state(promise1));
     EXPECT_EQ(V8PromiseCustom::Fulfilled, state(promise2));
     EXPECT_NE(promise1.v8Value(), promise2.v8Value());
 }
 
 } // namespace
 
 } // namespace WebCore