mash: Fix screen lock preload crash after login

chrome/browser/chromeos/login/lock/webui_screen_locker.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/chromeos/login/lock/webui_screen_locker.h"
 
 #include "ash/common/wm_shell.h"
 #include "ash/shell.h"
 #include "ash/system/chromeos/power/power_event_observer.h"
 #include "base/command_line.h"
 #include "base/feature_list.h"
 #include "base/metrics/histogram_macros.h"
 #include "base/strings/utf_string_conversions.h"
 #include "base/values.h"
 #include "chrome/browser/browser_shutdown.h"
 #include "chrome/browser/chrome_notification_types.h"
 #include "chrome/browser/chromeos/accessibility/accessibility_util.h"
 #include "chrome/browser/chromeos/login/helper.h"
 #include "chrome/browser/chromeos/login/lock/screen_locker.h"
 #include "chrome/browser/chromeos/login/ui/preloaded_web_view.h"
 #include "chrome/browser/chromeos/login/ui/preloaded_web_view_factory.h"
 #include "chrome/browser/chromeos/login/ui/webui_login_display.h"
 #include "chrome/browser/chromeos/profiles/profile_helper.h"
+#include "chrome/browser/ui/ash/ash_util.h"
 #include "chrome/browser/ui/webui/chromeos/login/oobe_ui.h"
 #include "chrome/browser/ui/webui/chromeos/login/signin_screen_handler.h"
 #include "chrome/common/chrome_features.h"
 #include "chrome/common/pref_names.h"
 #include "chrome/common/url_constants.h"
 #include "chrome/grit/generated_resources.h"
 #include "chromeos/dbus/dbus_thread_manager.h"
 #include "components/prefs/pref_service.h"
 #include "components/user_manager/user.h"
 #include "content/public/browser/browser_thread.h"
@@ skipping 40 matching lines @@
 
   VLOG(1) << "Preloading lock screen";
   PreloadedWebView* preloaded_web_view =
       PreloadedWebViewFactory::GetForProfile(ProfileHelper::GetSigninProfile());
   preloaded_web_view->PreloadOnIdle(
       base::BindOnce(&WebUIScreenLocker::DoPreload));
 }
 
 // static
 bool WebUIScreenLocker::ShouldPreloadLockScreen() {
+  // Bail for mash because IdleDetector/UserActivityDetector does not work
+  // properly there.
+  // TODO(xiyuan): Revisit after http://crbug.com/626899.
+  if (ash_util::IsRunningInMash())

[Daniel Erat, 2017/03/06 23:48:58]

the connection between this code and IdleDetector isn't obvious from looking at
this file. from the stack trace in crbug.com/698889, i'm guessing that
PreloadedWebView tries to defer loading the page until the user is idle or
something like that, right? would it be better to make PreloadedWebView just
load the page immediately when running under mash?

[xiyuan, 2017/03/06 23:54:50]

Your reading is correct. This is an optimization to make the lock screen show up
faster. Screen lock works without the preloading.

I don't want to preload it for mash because preloading makes it unnecessarily
slow and may make it unnecessarily complicated for mash work. Let's keep it
plain and simple for now. After we fix IdleDetector/UserActivityDetector for
chrome_on_mash, we can bring back the feature easily.

[Daniel Erat, 2017/03/07 01:27:16]

thanks for the explanation! would you mind also filing a mash bug to make sure
that we don't forget to wire this back up? :-) (or are you planning to retitle
crbug.com/698889 and use it?)

[xiyuan, 2017/03/07 17:00:07]

SG. Filed http://crbug.com/699144 to restore the reloading after 698889. 

+    return false;
+
   Profile* profile = ProfileHelper::Get()->GetProfileByUser(
       user_manager::UserManager::Get()->GetActiveUser());
 
   // We only want to preload the lock screen if the user is likely to see the
   // lock screen (since caching the lock screen uses memory). Without
   // preloading, showing the lock screen can take so long we will timeout and
   // crash the browser process (which currently takes down all of Chrome). See
   // crbug.com/452599 for more context.
   //
   // prefs::kEnableAutoScreenLock controls if the lock screen is shown on
@@ skipping 368 matching lines @@
   }
 
   if (GetOobeUI()) {
     const gfx::Size& size = primary_display.size();
     GetOobeUI()->GetCoreOobeView()->SetClientAreaSize(size.width(),
                                                       size.height());
   }
 }
 
 }  // namespace chromeos