Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(421)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2736733006: cros: Correctly initialize autofill client for SimpleWebViewDialog. (Closed)

Created:
3 years, 9 months ago by jdufault
Modified:
3 years, 9 months ago
Reviewers:
CC:
chromium-reviews, alemate+watch_chromium.org, vabr+watchlistpasswordmanager_chromium.org, achuith+watch_chromium.org, oshima+watch_chromium.org, gcasto+watchlist_chromium.org, davemoore+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

cros: Correctly initialize autofill client for SimpleWebViewDialog. I suspect that we have been incorrectly initializing for a long time, but the captive portal dialog never invoked autofill. If it did, it probably caused a crash. This[1] CL introduced an autofill warning if the user starts to type a password on an HTTP page. This surfaced the initialization error by crashing Chrome on the captive portal dialog. 1: https://chromium.googlesource.com/chromium/src/+/50592c0e5e6c21d5b11f3a5f1515d9afcd5fe1a7 BUG=678149

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M chrome/browser/chromeos/login/ui/simple_web_view_dialog.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/password_manager/chrome_password_manager_client.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 5 (5 generated)
jdufault
The CQ bit was checked by jdufault@chromium.org to run a CQ dry run
3 years, 9 months ago (2017-03-07 01:50:44 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2736733006/1
3 years, 9 months ago (2017-03-07 01:51:39 UTC) #2
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 9 months ago (2017-03-07 02:15:42 UTC) #3
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/401518)
3 years, 9 months ago (2017-03-07 02:15:43 UTC) #4
jdufault
3 years, 9 months ago (2017-03-07 02:16:23 UTC) #5 
Description was changed from

==========
cros: Correctly initialize autofill client for SimpleWebViewDialog.

I suspect that we have been incorrectly initializing for a long time,
but the captive portal dialog never invoked autofill. If it did, it
probably caused a crash.

This[1] CL introduced an autofill warning if the user starts to type a
password on an HTTP page. This surfaced the initialization error by
crashing Chrome on the captive portal dialog.

1:
https://chromium.googlesource.com/chromium/src/+/50592c0e5e6c21d5b11f3a5f1515...

BUG=678149
==========

to

==========
cros: Correctly initialize autofill client for SimpleWebViewDialog.

I suspect that we have been incorrectly initializing for a long time,
but the captive portal dialog never invoked autofill. If it did, it
probably caused a crash.

This[1] CL introduced an autofill warning if the user starts to type a
password on an HTTP page. This surfaced the initialization error by
crashing Chrome on the captive portal dialog.

1:
https://chromium.googlesource.com/chromium/src/+/50592c0e5e6c21d5b11f3a5f1515...

BUG=678149
==========

Powered by Google App Engine
This is Rietveld 408576698