Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(245)

Issue 2736733005: Manage and capture class and function instantiators in the parser. (Closed)

Created:
3 years, 9 months ago by regis
Modified:
3 years, 9 months ago
Reviewers:
hausner
CC:
reviews_dartlang.org, vm-dev_dartlang.org, siva
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Manage and capture class and function instantiators in the parser. This is work in progress towards supporting generic function semantics. R=hausner@google.com Committed: https://github.com/dart-lang/sdk/commit/09b5d6f619c415fcf885bffd868c1f09c1cd9989

Patch Set 1 #

Patch Set 2 : work in progress #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+201 lines, -109 lines) Patch
M runtime/vm/class_finalizer.cc View 1 chunk +18 lines, -14 lines 0 comments Download
M runtime/vm/code_descriptors_test.cc View 1 chunk +0 lines, -1 line 0 comments Download
M runtime/vm/object.cc View 3 chunks +15 lines, -4 lines 0 comments Download
M runtime/vm/parser.h View 1 5 chunks +14 lines, -2 lines 0 comments Download
M runtime/vm/parser.cc View 26 chunks +154 lines, -87 lines 2 comments Download
M runtime/vm/unit_test.cc View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 6 (2 generated)
regis
3 years, 9 months ago (2017-03-07 01:20:23 UTC) #2
hausner
LGTM https://codereview.chromium.org/2736733005/diff/20001/runtime/vm/parser.cc File runtime/vm/parser.cc (right): https://codereview.chromium.org/2736733005/diff/20001/runtime/vm/parser.cc#newcode3818 runtime/vm/parser.cc:3818: ident, NULL) != TypeParameter::null())) { Nit: weird formatting, ...
3 years, 9 months ago (2017-03-08 06:19:37 UTC) #3
regis
Thanks! https://codereview.chromium.org/2736733005/diff/20001/runtime/vm/parser.cc File runtime/vm/parser.cc (right): https://codereview.chromium.org/2736733005/diff/20001/runtime/vm/parser.cc#newcode3818 runtime/vm/parser.cc:3818: ident, NULL) != TypeParameter::null())) { On 2017/03/08 06:19:36, ...
3 years, 9 months ago (2017-03-08 16:18:49 UTC) #4
regis
3 years, 9 months ago (2017-03-08 16:55:38 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
09b5d6f619c415fcf885bffd868c1f09c1cd9989 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698