|
|
DescriptionFixed nonstatic constant structure which address shall be memoized.
Also performed "git cl format".
The bug appeared after patch https://codereview.chromium.org/2263503002/
It caused DCHECK fault in FeatureList::IsFeatureEnabled(),
DCHECK(CheckFeatureIdentity(feature))
R=thakis@chromium.org
BUG=
Patch Set 1 #
Messages
Total messages: 26 (21 generated)
The CQ bit was checked by merkin@yandex-team.ru to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: No L-G-T-M from a valid reviewer yet. CQ run can only be started by full committers or once the patch has received an L-G-T-M from a full committer. Even if an L-G-T-M may have been provided, it was from a non-committer, _not_ a full super star committer. Committers are members of the group "project-chromium-committers". Note that this has nothing to do with OWNERS files.
Description was changed from ========== Fixed nonstatic constant structure which address shall be memoized. Also performed "git cl format". R=thakis@chromium.org BUG= ========== to ========== Fixed nonstatic constant structure which address shall be memoized. Also performed "git cl format". The bug appeared after patch https://codereview.chromium.org/2263503002/ It caused DCHECK fault in FeatureList::IsFeatureEnabled(), DCHECK(CheckFeatureIdentity(feature)) R=thakis@chromium.org BUG= ==========
The CQ bit was checked by merkin@yandex-team.ru to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: No L-G-T-M from a valid reviewer yet. CQ run can only be started by full committers or once the patch has received an L-G-T-M from a full committer. Even if an L-G-T-M may have been provided, it was from a non-committer, _not_ a full super star committer. Committers are members of the group "project-chromium-committers". Note that this has nothing to do with OWNERS files.
grt@chromium.org changed reviewers: + grt@chromium.org
thanks. i have one out for review at https://codereview.chromium.org/2734133002/. nico: take your pick. :-)
lgtm may whatever gets through the cq first win
The CQ bit was checked by merkin@yandex-team.ru to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by merkin@yandex-team.ru
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
The CQ bit was checked by merkin@yandex-team.ru
The CQ bit was checked by merkin@yandex-team.ru to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...) |