Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Issue 2736723005: Fixed nonstatic constant structure which address shall be memoized. (Closed)

Created:
3 years, 9 months ago by merkin
Modified:
3 years, 9 months ago
Reviewers:
Nico, grt (UTC plus 2)
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fixed nonstatic constant structure which address shall be memoized. Also performed "git cl format". The bug appeared after patch https://codereview.chromium.org/2263503002/ It caused DCHECK fault in FeatureList::IsFeatureEnabled(), DCHECK(CheckFeatureIdentity(feature)) R=thakis@chromium.org BUG=

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M chrome/browser/upgrade_detector_impl.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 26 (21 generated)
merkin
3 years, 9 months ago (2017-03-07 11:14:02 UTC) #1
grt (UTC plus 2)
thanks. i have one out for review at https://codereview.chromium.org/2734133002/. nico: take your pick. :-)
3 years, 9 months ago (2017-03-07 11:29:17 UTC) #12
Nico
lgtm may whatever gets through the cq first win
3 years, 9 months ago (2017-03-07 15:16:27 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2736723005/1
3 years, 9 months ago (2017-03-07 17:28:57 UTC) #19
commit-bot: I haz the power
3 years, 9 months ago (2017-03-07 17:41:34 UTC) #21
Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

Powered by Google App Engine
This is Rietveld 408576698