Read internal properties [[PromiseStatus]] and [[PromiseValue]] of the promise.

Read internal properties [[PromiseStatus]] and [[PromiseValue]] of the promise.

BUG=v8:3093
LOG=N
R=aandrey@chromium.org, yangguo@chromium.org

Committed: https://code.google.com/p/v8/source/detail?r=21266

[Yang, 2014-05-08 14:56:33]

On 2014/05/08 14:49:31, Alexandra Mikhaylova wrote:

Why is this necessary, when we already have PromiseMirror.prototype.status and
PromiseMirror.prototype.value?

[Yang, 2014-05-08 14:57:51]

https://codereview.chromium.org/273653007/diff/1/src/mirror-debugger.js
File src/mirror-debugger.js (right):

https://codereview.chromium.org/273653007/diff/1/src/mirror-debugger.js#newco...
src/mirror-debugger.js:838: result.push(new InternalPropertyMirror("[[Value]]",
builtins.GetPromiseValue(value)));
please honor the 80-char limit.

[aandrey, 2014-05-08 15:05:16]

https://codereview.chromium.org/273653007/diff/1/src/mirror-debugger.js
File src/mirror-debugger.js (right):

https://codereview.chromium.org/273653007/diff/1/src/mirror-debugger.js#newco...
src/mirror-debugger.js:828: var promiseStatus =
builtins.GetPromiseStatus(value);
code dup. lets make a PromiseMirror:

var mirror = new PromiseMirror(value);
// use mirror.status();
// use mirror.promiseValue();

https://codereview.chromium.org/273653007/diff/1/src/mirror-debugger.js#newco...
src/mirror-debugger.js:837: result.push(new InternalPropertyMirror("[[Status]]",
statusString));
maybe [[PromiseStatus]], [[PromiseValue]] ?
what will you show in [[PromiseValue]] for a pending promise?

[aandrey, 2014-05-08 15:11:09]

On 2014/05/08 14:56:33, Yang wrote:
> On 2014/05/08 14:49:31, Alexandra Mikhaylova wrote:
> 
> Why is this necessary, when we already have PromiseMirror.prototype.status and
> PromiseMirror.prototype.value?

We'd like to show promise status/value in devtools console dump:
  console.dir(Promise.resolve(1));

We already do a similar thing for bound functions:
  console.dir(console.log.bind(console, "LOG: "))

[Alexandra Mikhaylova, 2014-05-08 15:20:58]

https://codereview.chromium.org/273653007/diff/1/src/mirror-debugger.js
File src/mirror-debugger.js (right):

https://codereview.chromium.org/273653007/diff/1/src/mirror-debugger.js#newco...
src/mirror-debugger.js:828: var promiseStatus =
builtins.GetPromiseStatus(value);
On 2014/05/08 15:05:16, aandrey wrote:
> code dup. lets make a PromiseMirror:
> 
> var mirror = new PromiseMirror(value);
> // use mirror.status();
> // use mirror.promiseValue();

Done.

https://codereview.chromium.org/273653007/diff/1/src/mirror-debugger.js#newco...
src/mirror-debugger.js:837: result.push(new InternalPropertyMirror("[[Status]]",
statusString));
On 2014/05/08 15:05:16, aandrey wrote:
> maybe [[PromiseStatus]], [[PromiseValue]] ?

Done.

> what will you show in [[PromiseValue]] for a pending promise?

For a pending promise, [[PromiseValue]] will be undefined.

https://codereview.chromium.org/273653007/diff/1/src/mirror-debugger.js#newco...
src/mirror-debugger.js:838: result.push(new InternalPropertyMirror("[[Value]]",
builtins.GetPromiseValue(value)));
On 2014/05/08 14:57:51, Yang wrote:
> please honor the 80-char limit.

Done.

[aandrey, 2014-05-08 15:27:04]

lgtm

https://codereview.chromium.org/273653007/diff/20001/test/mjsunit/es6/mirror-...
File test/mjsunit/es6/mirror-promises.js (right):

https://codereview.chromium.org/273653007/diff/20001/test/mjsunit/es6/mirror-...
test/mjsunit/es6/mirror-promises.js:72: var m1 = debug.MakeMirror(new Promise(
Promise.resolve(1)

https://codereview.chromium.org/273653007/diff/20001/test/mjsunit/es6/mirror-...
test/mjsunit/es6/mirror-promises.js:76: assertEquals("[[Status]]",
ip[0].name());
update these also

https://codereview.chromium.org/273653007/diff/20001/test/mjsunit/es6/mirror-...
test/mjsunit/es6/mirror-promises.js:81: var m2 = debug.MakeMirror(new
Promise(function(resolve, reject) { reject(2) }));
Promise.reject(2)

[Yang, 2014-05-09 13:02:50]

On 2014/05/08 15:27:04, aandrey wrote:
> lgtm
> 
>
https://codereview.chromium.org/273653007/diff/20001/test/mjsunit/es6/mirror-...
> File test/mjsunit/es6/mirror-promises.js (right):
> 
>
https://codereview.chromium.org/273653007/diff/20001/test/mjsunit/es6/mirror-...
> test/mjsunit/es6/mirror-promises.js:72: var m1 = debug.MakeMirror(new Promise(
> Promise.resolve(1)
> 
>
https://codereview.chromium.org/273653007/diff/20001/test/mjsunit/es6/mirror-...
> test/mjsunit/es6/mirror-promises.js:76: assertEquals("[[Status]]",
> ip[0].name());
> update these also
> 
>
https://codereview.chromium.org/273653007/diff/20001/test/mjsunit/es6/mirror-...
> test/mjsunit/es6/mirror-promises.js:81: var m2 = debug.MakeMirror(new
> Promise(function(resolve, reject) { reject(2) }));
> Promise.reject(2)

I still don't know where this is used or why this is necessary. It's a different
code path for doing the same thing, right?

[aandrey, 2014-05-09 13:39:57]

On 2014/05/09 13:02:50, Yang wrote:
> On 2014/05/08 15:27:04, aandrey wrote:
> > lgtm
> > 
> >
>
https://codereview.chromium.org/273653007/diff/20001/test/mjsunit/es6/mirror-...
> > File test/mjsunit/es6/mirror-promises.js (right):
> > 
> >
>
https://codereview.chromium.org/273653007/diff/20001/test/mjsunit/es6/mirror-...
> > test/mjsunit/es6/mirror-promises.js:72: var m1 = debug.MakeMirror(new
Promise(
> > Promise.resolve(1)
> > 
> >
>
https://codereview.chromium.org/273653007/diff/20001/test/mjsunit/es6/mirror-...
> > test/mjsunit/es6/mirror-promises.js:76: assertEquals("[[Status]]",
> > ip[0].name());
> > update these also
> > 
> >
>
https://codereview.chromium.org/273653007/diff/20001/test/mjsunit/es6/mirror-...
> > test/mjsunit/es6/mirror-promises.js:81: var m2 = debug.MakeMirror(new
> > Promise(function(resolve, reject) { reject(2) }));
> > Promise.reject(2)
> 
> I still don't know where this is used or why this is necessary. It's a
different
> code path for doing the same thing, right?

We call getProperties and getInternalProperties on an object to dump it in
console.
Now, for a Promise instance we return empty properties. We would like to show
status and value.
Try to run in console: console.dir(Promise.resolve(1));

[Yang, 2014-05-12 12:31:41]

LGTM. I'll address the comment myself and land this.

https://codereview.chromium.org/273653007/diff/40001/src/mirror-debugger.js
File src/mirror-debugger.js (right):

https://codereview.chromium.org/273653007/diff/40001/src/mirror-debugger.js#n...
src/mirror-debugger.js:827: var mirror = new PromiseMirror(value);
indentation.

[Yang, 2014-05-12 12:42:41]

Committed patchset #3 manually as r21266 (presubmit successful).

[Yang, 2014-05-12 13:38:07]

On 2014/05/12 12:42:41, Yang wrote:
> Committed patchset #3 manually as r21266 (presubmit successful).

I have to revert this because webkit layout test
"inspector/console/console-dir-global.html" fails due to this. We can try again
once you have set its expectation to requiring manual rebaseline.