Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(74)

Issue 273653006: Cleaned up the weak lists hanging off the heap a bit. (Closed)

Created:
6 years, 7 months ago by Sven Panne
Modified:
6 years, 7 months ago
Reviewers:
Michael Starzinger
CC:
v8-dev
Visibility:
Public.

Description

Cleaned up the weak lists hanging off the heap a bit. * Route all access to the 3 weak lists through getters/setters. * Removed superfluous visiting already done by ProcessWeakReferences. R=mstarzinger@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=21207

Patch Set 1 #

Patch Set 2 : Rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -24 lines) Patch
M src/heap.h View 1 2 chunks +4 lines, -7 lines 0 comments Download
M src/heap.cc View 1 7 chunks +10 lines, -13 lines 0 comments Download
M src/mark-compact.cc View 2 chunks +1 line, -4 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Sven Panne
6 years, 7 months ago (2014-05-08 13:17:29 UTC) #1
Michael Starzinger
LGTM.
6 years, 7 months ago (2014-05-08 13:31:26 UTC) #2
Sven Panne
6 years, 7 months ago (2014-05-09 09:02:52 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 manually as r21207 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698