Oilpan: Prepare to move PickerIndicatorElement to Oilpan heap.

Oilpan: Prepare to move PickerIndicatorElement to Oilpan heap.

BUG=357163
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=173607

[haraken, 2014-05-07 14:54:19]

LGTM

[haraken, 2014-05-07 15:00:04]

https://codereview.chromium.org/273653003/diff/1/Source/core/html/shadow/Pick...
File Source/core/html/shadow/PickerIndicatorElement.h (right):

https://codereview.chromium.org/273653003/diff/1/Source/core/html/shadow/Pick...
Source/core/html/shadow/PickerIndicatorElement.h:82:
RawPtrWillBeWeakMember<PickerIndicatorOwner> m_pickerIndicatorOwner;

As Mads is commenting in https://codereview.chromium.org/267413002/#msg8 , this
can be RawPtrWillBeMember, since the PickerIndicatorOwner and the PickerElement
should die together.

[tkent, 2014-05-08 01:20:06]

https://codereview.chromium.org/273653003/diff/1/Source/core/html/shadow/Pick...
File Source/core/html/shadow/PickerIndicatorElement.h (right):

https://codereview.chromium.org/273653003/diff/1/Source/core/html/shadow/Pick...
Source/core/html/shadow/PickerIndicatorElement.h:82:
RawPtrWillBeWeakMember<PickerIndicatorOwner> m_pickerIndicatorOwner;
On 2014/05/07 15:00:04, haraken wrote:
> 
> As Mads is commenting in https://codereview.chromium.org/267413002/#msg8 ,
this
> can be RawPtrWillBeMember, since the PickerIndicatorOwner and the
PickerElement
> should die together.

That's right.

[keishi, 2014-05-08 01:47:44]

https://codereview.chromium.org/273653003/diff/1/Source/core/html/shadow/Pick...
File Source/core/html/shadow/PickerIndicatorElement.h (right):

https://codereview.chromium.org/273653003/diff/1/Source/core/html/shadow/Pick...
Source/core/html/shadow/PickerIndicatorElement.h:82:
RawPtrWillBeWeakMember<PickerIndicatorOwner> m_pickerIndicatorOwner;
On 2014/05/07 15:00:04, haraken wrote:
> 
> As Mads is commenting in https://codereview.chromium.org/267413002/#msg8 ,
this
> can be RawPtrWillBeMember, since the PickerIndicatorOwner and the
PickerElement
> should die together.

Done.

[tkent, 2014-05-08 01:54:31]

lgtm

https://codereview.chromium.org/273653003/diff/10001/Source/core/html/shadow/...
File Source/core/html/shadow/PickerIndicatorElement.h (right):

https://codereview.chromium.org/273653003/diff/10001/Source/core/html/shadow/...
Source/core/html/shadow/PickerIndicatorElement.h:45:
WILL_BE_USING_GARBAGE_COLLECTED_MIXIN(PickerIndicatorElement);
This looks unnecessary.

[keishi, 2014-05-08 05:54:00]

https://codereview.chromium.org/273653003/diff/10001/Source/core/html/shadow/...
File Source/core/html/shadow/PickerIndicatorElement.h (right):

https://codereview.chromium.org/273653003/diff/10001/Source/core/html/shadow/...
Source/core/html/shadow/PickerIndicatorElement.h:45:
WILL_BE_USING_GARBAGE_COLLECTED_MIXIN(PickerIndicatorElement);
On 2014/05/08 01:54:32, tkent wrote:
> This looks unnecessary.

Done.

[keishi, 2014-05-08 05:54:07]

The CQ bit was checked by keishi@chromium.org

[commit-bot: I haz the power, 2014-05-08 05:54:38]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/keishi@chromium.org/273653003/30001

[commit-bot: I haz the power, 2014-05-08 06:51:35]

Change committed as 173607

[zerny-chromium, 2014-05-09 06:18:48]

lgtm (was confused for a moment since there is no change to the class
implementing the mixin, but BaseMultipleFieldsDateAndTimeInputType is already
using other mixins :-)