Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(353)

Issue 273653002: Parser / PreParser: Simplify error message arguments. (Closed)

Created:
6 years, 7 months ago by marja
Modified:
6 years, 7 months ago
Reviewers:
ulan
CC:
v8-dev
Visibility:
Public.

Description

Parser / PreParser: Simplify error message arguments. In some places, we pretended that there can be multiple arguments, though in practice there was only one. In other places (most importantly, PreParser), we only handled one argument. (This means that we were not able to produce a multi-argument error inside a lazy function anyway.) This CL makes it clear that there is ever only one argument. R=ulan@chromium.org BUG= Committed: https://code.google.com/p/v8/source/detail?r=21324

Patch Set 1 #

Total comments: 2

Patch Set 2 : rebased #

Patch Set 3 : code review (ulan@) #

Patch Set 4 : rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+69 lines, -119 lines) Patch
M src/parser.h View 1 2 2 chunks +4 lines, -4 lines 0 comments Download
M src/parser.cc View 1 2 26 chunks +44 lines, -76 lines 0 comments Download
M src/preparser.h View 5 chunks +9 lines, -14 lines 0 comments Download
M src/preparser.cc View 2 chunks +6 lines, -16 lines 0 comments Download
M test/cctest/test-parsing.cc View 2 chunks +6 lines, -9 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
marja
ulan, ptal
6 years, 7 months ago (2014-05-07 11:37:55 UTC) #1
ulan
lgtm https://codereview.chromium.org/273653002/diff/1/src/parser.cc File src/parser.cc (right): https://codereview.chromium.org/273653002/diff/1/src/parser.cc#newcode652 src/parser.cc:652: Handle<String> arg, You can use MaybeHandle here to ...
6 years, 7 months ago (2014-05-07 14:12:32 UTC) #2
marja
thx for review https://codereview.chromium.org/273653002/diff/1/src/parser.cc File src/parser.cc (right): https://codereview.chromium.org/273653002/diff/1/src/parser.cc#newcode652 src/parser.cc:652: Handle<String> arg, On 2014/05/07 14:12:32, ulan ...
6 years, 7 months ago (2014-05-12 13:40:27 UTC) #3
ulan
lgtm
6 years, 7 months ago (2014-05-12 13:43:59 UTC) #4
marja
6 years, 7 months ago (2014-05-15 09:45:05 UTC) #5
Message was sent while issue was closed.
Committed patchset #4 manually as r21324 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698