Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1835)

Unified Diff: third_party/WebKit/Source/web/WebViewImpl.cpp

Issue 2736523002: Defer ChromeClient::attachRootGraphicsLayer until after compositing update. (Closed)
Patch Set: rebase Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/core/layout/compositing/PaintLayerCompositor.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/web/WebViewImpl.cpp
diff --git a/third_party/WebKit/Source/web/WebViewImpl.cpp b/third_party/WebKit/Source/web/WebViewImpl.cpp
index 7e31817abf33c8d1de944ee18ec1f3c55a90ce2c..05ff38f2f8776437445527b12297ff3c72907a88 100644
--- a/third_party/WebKit/Source/web/WebViewImpl.cpp
+++ b/third_party/WebKit/Source/web/WebViewImpl.cpp
@@ -3735,7 +3735,13 @@ void WebViewImpl::setPageOverlayColor(WebColor color) {
m_pageColorOverlay = PageOverlay::create(
mainFrameImpl(), WTF::makeUnique<ColorOverlay>(color));
- m_pageColorOverlay->update();
+
+ // Run compositing update before calling updatePageOverlays.
+ mainFrameImpl()
+ ->frameView()
+ ->updateLifecycleToCompositingCleanPlusScrolling();
+
+ updatePageOverlays();
}
WebPageImportanceSignals* WebViewImpl::pageImportanceSignals() {
« no previous file with comments | « third_party/WebKit/Source/core/layout/compositing/PaintLayerCompositor.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698