Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(584)

Unified Diff: third_party/WebKit/Source/core/layout/compositing/PaintLayerCompositor.h

Issue 2736523002: Defer ChromeClient::attachRootGraphicsLayer until after compositing update. (Closed)
Patch Set: rebase Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/layout/compositing/PaintLayerCompositor.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/layout/compositing/PaintLayerCompositor.h
diff --git a/third_party/WebKit/Source/core/layout/compositing/PaintLayerCompositor.h b/third_party/WebKit/Source/core/layout/compositing/PaintLayerCompositor.h
index 68ffabf78b70fb2dc47bb981f2fa9d10c6727b90..6a281590ea4db3941333c6969560b9f05b2ae1dd 100644
--- a/third_party/WebKit/Source/core/layout/compositing/PaintLayerCompositor.h
+++ b/third_party/WebKit/Source/core/layout/compositing/PaintLayerCompositor.h
@@ -129,16 +129,6 @@ class CORE_EXPORT PaintLayerCompositor final : public GraphicsLayerClient {
GraphicsLayer* containerLayer() const;
GraphicsLayer* rootContentLayer() const;
- enum RootLayerAttachment {
- RootLayerUnattached,
- RootLayerAttachedViaChromeClient,
- RootLayerAttachedViaEnclosingFrame
- };
-
- RootLayerAttachment getRootLayerAttachment() const {
- return m_rootLayerAttachment;
- }
- void updateRootLayerAttachment();
void updateRootLayerPosition();
// If the root scroller isn't the root layer then the PaintLayerCompositor
@@ -218,7 +208,7 @@ class CORE_EXPORT PaintLayerCompositor final : public GraphicsLayerClient {
void ensureRootLayer();
void destroyRootLayer();
- void attachRootLayer(RootLayerAttachment);
+ void attachRootLayer();
void detachRootLayer();
void attachCompositorTimeline();
@@ -270,6 +260,12 @@ class CORE_EXPORT PaintLayerCompositor final : public GraphicsLayerClient {
bool m_isTrackingRasterInvalidations; // Used for testing.
bool m_inOverlayFullscreenVideo;
+ enum RootLayerAttachment {
+ RootLayerUnattached,
+ RootLayerPendingAttachViaChromeClient,
+ RootLayerAttachedViaChromeClient,
+ RootLayerAttachedViaEnclosingFrame
+ };
RootLayerAttachment m_rootLayerAttachment;
// Enclosing container layer, which clips for iframe content
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/layout/compositing/PaintLayerCompositor.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698