third_party/WebKit/Source/web/WebViewImpl.cpp - Issue 2736523002: Defer ChromeClient::attachRootGraphicsLayer until after compositing update.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/web/WebViewImpl.cpp

Issue 2736523002: Defer ChromeClient::attachRootGraphicsLayer until after compositing update. (Closed)

Patch Set: use updateLifecycleToCompositingCleanPlusScrolling Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/web/WebViewImpl.cpp

diff --git a/third_party/WebKit/Source/web/WebViewImpl.cpp b/third_party/WebKit/Source/web/WebViewImpl.cpp

index a14899a44e8bbb407cce2a174f07682c7ebdcd15..0e92aac0a24314ad05ee9044503c9b071aeb8bfb 100644

--- a/third_party/WebKit/Source/web/WebViewImpl.cpp

+++ b/third_party/WebKit/Source/web/WebViewImpl.cpp

@@ -3727,7 +3727,13 @@ void WebViewImpl::setPageOverlayColor(WebColor color) {

m_pageColorOverlay = PageOverlay::create(

mainFrameImpl(), WTF::makeUnique<ColorOverlay>(color));

- m_pageColorOverlay->update();

+ // Run compositing update before calling updatePageOverlays.

+ mainFrameImpl()

+ ->frameView()

+ ->updateLifecycleToCompositingCleanPlusScrolling();

+ updatePageOverlays();

}

WebPageImportanceSignals* WebViewImpl::pageImportanceSignals() {