third_party/WebKit/Source/core/paint/FindPropertiesNeedingUpdate.h - Issue 2736463002: [SPv2] Fix property node invalidation for CSS masks

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/paint/FindPropertiesNeedingUpdate.h

Issue 2736463002: [SPv2] Fix property node invalidation for CSS masks (Closed)

Patch Set: Avoid SVGRoot can of worms Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/paint/FindPropertiesNeedingUpdate.h

diff --git a/third_party/WebKit/Source/core/paint/FindPropertiesNeedingUpdate.h b/third_party/WebKit/Source/core/paint/FindPropertiesNeedingUpdate.h

index 673c3661fcf3386034932a4c241aa0cfa5bad553..b9f89bcbe3d8a2ca1a6959d00148d2765833742d 100644

--- a/third_party/WebKit/Source/core/paint/FindPropertiesNeedingUpdate.h

+++ b/third_party/WebKit/Source/core/paint/FindPropertiesNeedingUpdate.h

@@ -142,6 +142,12 @@ class FindObjectPropertiesNeedingUpdateScope {

objectProperties->transform());

DCHECK_OBJECT_PROPERTY_EQ(m_object, m_originalProperties->effect(),

objectProperties->effect());

+ DCHECK_OBJECT_PROPERTY_EQ(m_object, m_originalProperties->filter(),

+ objectProperties->filter());

+ DCHECK_OBJECT_PROPERTY_EQ(m_object, m_originalProperties->mask(),

+ objectProperties->mask());

+ DCHECK_OBJECT_PROPERTY_EQ(m_object, m_originalProperties->maskClip(),

+ objectProperties->maskClip());

DCHECK_OBJECT_PROPERTY_EQ(m_object, m_originalProperties->cssClip(),

objectProperties->cssClip());

DCHECK_OBJECT_PROPERTY_EQ(m_object,