Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(75)

Side by Side Diff: third_party/WebKit/Source/core/layout/LayoutBox.cpp

Issue 2736463002: [SPv2] Fix property node invalidation for CSS masks (Closed)
Patch Set: Avoid SVGRoot can of worms Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/paint/FindPropertiesNeedingUpdate.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 1999 Antti Koivisto (koivisto@kde.org) 3 * (C) 1999 Antti Koivisto (koivisto@kde.org)
4 * (C) 2005 Allan Sandfeld Jensen (kde@carewolf.com) 4 * (C) 2005 Allan Sandfeld Jensen (kde@carewolf.com)
5 * (C) 2005, 2006 Samuel Weinig (sam.weinig@gmail.com) 5 * (C) 2005, 2006 Samuel Weinig (sam.weinig@gmail.com)
6 * Copyright (C) 2005, 2006, 2007, 2008, 2009, 2010 Apple Inc. 6 * Copyright (C) 2005, 2006, 2007, 2008, 2009, 2010 Apple Inc.
7 * All rights reserved. 7 * All rights reserved.
8 * Copyright (C) 2013 Adobe Systems Incorporated. All rights reserved. 8 * Copyright (C) 2013 Adobe Systems Incorporated. All rights reserved.
9 * 9 *
10 * This library is free software; you can redistribute it and/or 10 * This library is free software; you can redistribute it and/or
(...skipping 2266 matching lines...) Expand 10 before | Expand all | Expand 10 after
2277 : classABreakPointValue(previousBreakAfterValue); 2277 : classABreakPointValue(previousBreakAfterValue);
2278 return isForcedFragmentainerBreakValue(breakValue); 2278 return isForcedFragmentainerBreakValue(breakValue);
2279 } 2279 }
2280 2280
2281 bool LayoutBox::paintedOutputOfObjectHasNoEffectRegardlessOfSize() const { 2281 bool LayoutBox::paintedOutputOfObjectHasNoEffectRegardlessOfSize() const {
2282 if (hasNonCompositedScrollbars() || getSelectionState() != SelectionNone || 2282 if (hasNonCompositedScrollbars() || getSelectionState() != SelectionNone ||
2283 hasBoxDecorationBackground() || styleRef().hasBoxDecorations() || 2283 hasBoxDecorationBackground() || styleRef().hasBoxDecorations() ||
2284 styleRef().hasVisualOverflowingEffect()) 2284 styleRef().hasVisualOverflowingEffect())
2285 return false; 2285 return false;
2286 2286
2287 // If the box has clip or mask, we need issue paint invalidation to cover 2287 // Both mask and clip-path generates drawing display items that depends on
2288 // the size of the box.
2289 if (hasMask() || hasClipPath())
2290 return false;
2291
2292 // If the box has any kind of clip, we need issue paint invalidation to cover
2288 // the changed part of children when the box got resized. In SPv2 this is 2293 // the changed part of children when the box got resized. In SPv2 this is
2289 // handled by detecting paint property changes. 2294 // handled by detecting paint property changes.
2290 if (!RuntimeEnabledFeatures::slimmingPaintV2Enabled()) { 2295 if (!RuntimeEnabledFeatures::slimmingPaintV2Enabled()) {
2291 if (hasClipRelatedProperty() || hasControlClip() || hasMask()) 2296 if (hasClipRelatedProperty() || hasControlClip())
2292 return false; 2297 return false;
2293 } 2298 }
2294 2299
2295 // If the box paints into its own backing, we can assume that it's painting 2300 // If the box paints into its own backing, we can assume that it's painting
2296 // may have some effect. For example, honoring the border-radius clip on 2301 // may have some effect. For example, honoring the border-radius clip on
2297 // a composited child paints into a mask for an otherwise non-painting 2302 // a composited child paints into a mask for an otherwise non-painting
2298 // element, because children of that element will require the mask. 2303 // element, because children of that element will require the mask.
2299 if (hasLayer() && layer()->compositingState() == PaintsIntoOwnBacking) 2304 if (hasLayer() && layer()->compositingState() == PaintsIntoOwnBacking)
2300 return false; 2305 return false;
2301 2306
(...skipping 3443 matching lines...) Expand 10 before | Expand all | Expand 10 after
5745 5750
5746 void LayoutBox::MutableForPainting:: 5751 void LayoutBox::MutableForPainting::
5747 savePreviousContentBoxSizeAndLayoutOverflowRect() { 5752 savePreviousContentBoxSizeAndLayoutOverflowRect() {
5748 auto& rareData = layoutBox().ensureRareData(); 5753 auto& rareData = layoutBox().ensureRareData();
5749 rareData.m_hasPreviousContentBoxSizeAndLayoutOverflowRect = true; 5754 rareData.m_hasPreviousContentBoxSizeAndLayoutOverflowRect = true;
5750 rareData.m_previousContentBoxSize = layoutBox().contentBoxRect().size(); 5755 rareData.m_previousContentBoxSize = layoutBox().contentBoxRect().size();
5751 rareData.m_previousLayoutOverflowRect = layoutBox().layoutOverflowRect(); 5756 rareData.m_previousLayoutOverflowRect = layoutBox().layoutOverflowRect();
5752 } 5757 }
5753 5758
5754 } // namespace blink 5759 } // namespace blink
OLDNEW
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/paint/FindPropertiesNeedingUpdate.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698