components/password_manager/content/browser/content_password_manager_driver.cc - Issue 2736393003: Clear password values before sending them to the renderer process.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/password_manager/content/browser/content_password_manager_driver.cc

Issue 2736393003: Clear password values before sending them to the renderer process. (Closed)

Patch Set: Addressed comments Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/autofill/core/common/password_form_fill_data.cc ('k') | components/password_manager/content/browser/content_password_manager_driver_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/password_manager/content/browser/content_password_manager_driver.cc

diff --git a/components/password_manager/content/browser/content_password_manager_driver.cc b/components/password_manager/content/browser/content_password_manager_driver.cc

index 4058abb1f43ec22ef2cac7b8210b5b2cc36ea8b5..52ed13007579d1974d1a7354d5dd9e8e9705274c 100644

--- a/components/password_manager/content/browser/content_password_manager_driver.cc

+++ b/components/password_manager/content/browser/content_password_manager_driver.cc

@@ -85,7 +85,8 @@ void ContentPasswordManagerDriver::FillPasswordForm(

const autofill::PasswordFormFillData& form_data) {

const int key = next_free_key_++;

password_autofill_manager_.OnAddPasswordFormMapping(key, form_data);

- GetPasswordAutofillAgent()->FillPasswordForm(key, form_data);

+ GetPasswordAutofillAgent()->FillPasswordForm(

+ key, autofill::ClearPasswordValues(form_data));

}

void ContentPasswordManagerDriver::AllowPasswordGenerationForForm(