Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(66)

Unified Diff: ios/chrome/browser/tabs/tab.mm

Issue 2736383006: Removed CRWWebDelagate callbacks for load cancellation. (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | ios/web/public/web_state/ui/crw_web_delegate.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ios/chrome/browser/tabs/tab.mm
diff --git a/ios/chrome/browser/tabs/tab.mm b/ios/chrome/browser/tabs/tab.mm
index 7301b09ff9e1243b9b10fcc3ad6cbc3d18c7e164..6baeb0de06d4a48436ba35f624f577b9b051851b 100644
--- a/ios/chrome/browser/tabs/tab.mm
+++ b/ios/chrome/browser/tabs/tab.mm
@@ -1666,11 +1666,6 @@ void TabInfoBarObserver::OnInfoBarReplaced(infobars::InfoBar* old_infobar,
object:self];
}
-- (void)webCancelStartLoadingRequest {
Eugene But (OOO till 7-30) 2017/03/10 23:43:00 webStateDidStopLoading: is also called when provis
- DCHECK(self.webController.loadPhase == web::PAGE_LOADED);
- [parentTabModel_ notifyTabChanged:self];
-}
-
- (void)webState:(web::WebState*)webState
didCommitNavigationWithDetails:(const web::LoadCommittedDetails&)details {
DCHECK([self navigationManager]);
@@ -1801,8 +1796,9 @@ void TabInfoBarObserver::OnInfoBarReplaced(infobars::InfoBar* old_infobar,
[parentTabModel_ notifyTabChanged:self];
}
-- (void)webLoadCancelled:(const GURL&)url {
- // When a load is cancelled, this is the maximum that a page will ever load.
+- (void)webStateDidStopLoading:(web::WebState*)webState {
+ // This is the maximum that a page will ever load and it is safe to allow
+ // fullscreen mode.
[fullScreenController_ enableFullScreen];
[parentTabModel_ notifyTabChanged:self];
}
« no previous file with comments | « no previous file | ios/web/public/web_state/ui/crw_web_delegate.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698