Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(158)

Issue 2736383005: Store type inference errors into EntityRef. (Closed)

Created:
3 years, 9 months ago by scheglov
Modified:
3 years, 9 months ago
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Store type inference errors into EntityRef. The errors will be associated with inference targets - top-level variables, static class fields, instance class fields, overriding instance method parameters with conflicting type in overridden members, etc. These errors will be accessible through corresponding Element(s) and reported by LibraryAnalyzer, and so AnalysisDriver to the client. So, we will not need to compute these errors once again in ErrorVerifier. R=brianwilkerson@google.com, paulberry@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/ee3dca40c799ac43f3bac6ff15fbc2a70c02339d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+144 lines, -1 line) Patch
M pkg/analyzer/lib/src/summary/format.dart View 12 chunks +123 lines, -1 line 0 comments Download
M pkg/analyzer/lib/src/summary/format.fbs View Binary file 0 comments Download
M pkg/analyzer/lib/src/summary/idl.dart View 2 chunks +21 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
scheglov
3 years, 9 months ago (2017-03-10 20:05:43 UTC) #1
Paul Berry
lgtm
3 years, 9 months ago (2017-03-10 20:19:22 UTC) #2
Brian Wilkerson
lgtm
3 years, 9 months ago (2017-03-10 20:46:38 UTC) #3
scheglov
3 years, 9 months ago (2017-03-10 21:04:18 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
ee3dca40c799ac43f3bac6ff15fbc2a70c02339d (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698