Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(40)

Side by Side Diff: chrome/browser/about_flags.cc

Issue 2736293002: Add chrome flags entry for ChromeVox ARC support (Closed)
Patch Set: Address feedback. Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/about_flags.h" 5 #include "chrome/browser/about_flags.h"
6 6
7 #include <iterator> 7 #include <iterator>
8 #include <map> 8 #include <map>
9 #include <set> 9 #include <set>
10 #include <utility> 10 #include <utility>
(...skipping 2328 matching lines...) Expand 10 before | Expand all | Expand 10 after
2339 FEATURE_VALUE_TYPE(chrome::android::kCustomFeedbackUi)}, 2339 FEATURE_VALUE_TYPE(chrome::android::kCustomFeedbackUi)},
2340 #endif // OS_ANDROID 2340 #endif // OS_ANDROID
2341 2341
2342 {"enable-resource-prefetch", IDS_FLAGS_SPECULATIVE_PREFETCH_NAME, 2342 {"enable-resource-prefetch", IDS_FLAGS_SPECULATIVE_PREFETCH_NAME,
2343 IDS_FLAGS_SPECULATIVE_PREFETCH_DESCRIPTION, kOsAll, 2343 IDS_FLAGS_SPECULATIVE_PREFETCH_DESCRIPTION, kOsAll,
2344 FEATURE_WITH_VARIATIONS_VALUE_TYPE( 2344 FEATURE_WITH_VARIATIONS_VALUE_TYPE(
2345 predictors::kSpeculativeResourcePrefetchingFeature, 2345 predictors::kSpeculativeResourcePrefetchingFeature,
2346 kSpeculativeResourcePrefetchingFeatureVariations, 2346 kSpeculativeResourcePrefetchingFeatureVariations,
2347 "SpeculativeResourcePrefetchingValidation")}, 2347 "SpeculativeResourcePrefetchingValidation")},
2348 2348
2349 #if defined(OS_CHROMEOS)
2350 {"enable-chromevox-arc-support", IDS_FLAGS_SHOW_ARC_FILES_APP_NAME,
yawano 2017/03/13 02:07:18 nit: IDS_FLAGS_ENABLE_CHROMEVOX_ARC_SUPPORT_NAME
David Tseng 2017/03/13 20:18:03 Ugg. Yup added. Thanks.
2351 IDS_FLAGS_ENABLE_CHROMEVOX_ARC_SUPPORT_DESCRIPTION, kOsCrOS,
2352 SINGLE_VALUE_TYPE(chromeos::switches::kEnableChromeVoxArcSupport)},
2353 #endif // defined(OS_CHROMEOS)
2354
2349 // NOTE: Adding new command-line switches requires adding corresponding 2355 // NOTE: Adding new command-line switches requires adding corresponding
2350 // entries to enum "LoginCustomFlags" in histograms.xml. See note in 2356 // entries to enum "LoginCustomFlags" in histograms.xml. See note in
2351 // histograms.xml and don't forget to run AboutFlagsHistogramTest unit test. 2357 // histograms.xml and don't forget to run AboutFlagsHistogramTest unit test.
2352 }; 2358 };
2353 2359
2354 class FlagsStateSingleton { 2360 class FlagsStateSingleton {
2355 public: 2361 public:
2356 FlagsStateSingleton() 2362 FlagsStateSingleton()
2357 : flags_state_(kFeatureEntries, arraysize(kFeatureEntries)) {} 2363 : flags_state_(kFeatureEntries, arraysize(kFeatureEntries)) {}
2358 ~FlagsStateSingleton() {} 2364 ~FlagsStateSingleton() {}
(...skipping 188 matching lines...) Expand 10 before | Expand all | Expand 10 after
2547 const base::HistogramBase::Sample kBadSwitchFormatHistogramId = 0; 2553 const base::HistogramBase::Sample kBadSwitchFormatHistogramId = 0;
2548 2554
2549 const FeatureEntry* GetFeatureEntries(size_t* count) { 2555 const FeatureEntry* GetFeatureEntries(size_t* count) {
2550 *count = arraysize(kFeatureEntries); 2556 *count = arraysize(kFeatureEntries);
2551 return kFeatureEntries; 2557 return kFeatureEntries;
2552 } 2558 }
2553 2559
2554 } // namespace testing 2560 } // namespace testing
2555 2561
2556 } // namespace about_flags 2562 } // namespace about_flags
OLDNEW
« no previous file with comments | « chrome/app/generated_resources.grd ('k') | chrome/browser/chromeos/arc/intent_helper/arc_settings_service.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698