Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Unified Diff: services/resource_coordinator/memory/coordinator/coordinator_impl.cc

Issue 2736283003: [memory-infra] MemoryDumpScheduler follows config for time between dumps (Closed)
Patch Set: rebase. Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: services/resource_coordinator/memory/coordinator/coordinator_impl.cc
diff --git a/services/resource_coordinator/memory/coordinator/coordinator_impl.cc b/services/resource_coordinator/memory/coordinator/coordinator_impl.cc
index 5c133f803c472c845b70ba40936c9706365beaa7..c582e23b5924f4bd4d1fb2a43a2228c662e630d0 100644
--- a/services/resource_coordinator/memory/coordinator/coordinator_impl.cc
+++ b/services/resource_coordinator/memory/coordinator/coordinator_impl.cc
@@ -55,11 +55,12 @@ void CoordinatorImpl::RequestGlobalMemoryDump(
bool another_dump_already_in_progress = !queued_memory_dump_requests_.empty();
- // If this is a periodic memory dump request and there already is another
- // request in the queue with the same level of detail, there's no point in
- // enqueuing this request.
+ // If this is a periodic or peak memory dump request and there already is
+ // another request in the queue with the same level of detail, there's no
+ // point in enqueuing this request.
if (another_dump_already_in_progress &&
- args.dump_type == base::trace_event::MemoryDumpType::PERIODIC_INTERVAL) {
+ args.dump_type !=
+ base::trace_event::MemoryDumpType::EXPLICITLY_TRIGGERED) {
for (const auto& request : queued_memory_dump_requests_) {
if (request.args.level_of_detail == args.level_of_detail) {
VLOG(1) << base::trace_event::MemoryDumpManager::kLogPrefix << " ("
« base/trace_event/memory_dump_scheduler.cc ('K') | « base/trace_event/memory_dump_scheduler.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698