Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(440)

Issue 273623003: Make valgrind happy (Closed)

Created:
6 years, 7 months ago by achaulk
Modified:
6 years, 7 months ago
Reviewers:
Zachary Kuznia
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Make valgrind happy BUG=359299 TEST=valgrind unittests TBR=zork@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=269587

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -2 lines) Patch
M components/feedback/OWNERS View 1 chunk +1 line, -1 line 0 comments Download
M components/feedback/feedback_uploader_unittest.cc View 2 chunks +3 lines, -1 line 0 comments Download

Messages

Total messages: 10 (0 generated)
achaulk
6 years, 7 months ago (2014-05-09 15:15:57 UTC) #1
achaulk
The CQ bit was checked by achaulk@chromium.org
6 years, 7 months ago (2014-05-09 15:15:58 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/achaulk@chromium.org/273623003/1
6 years, 7 months ago (2014-05-09 15:18:46 UTC) #3
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-05-09 15:18:47 UTC) #4
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
6 years, 7 months ago (2014-05-09 15:18:48 UTC) #5
Zachary Kuznia
lgtm
6 years, 7 months ago (2014-05-09 17:12:46 UTC) #6
achaulk
The CQ bit was checked by achaulk@chromium.org
6 years, 7 months ago (2014-05-09 18:11:07 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/achaulk@chromium.org/273623003/1
6 years, 7 months ago (2014-05-09 18:13:44 UTC) #8
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are ...
6 years, 7 months ago (2014-05-09 22:17:15 UTC) #9
commit-bot: I haz the power
6 years, 7 months ago (2014-05-10 18:13:55 UTC) #10
Message was sent while issue was closed.
Change committed as 269587

Powered by Google App Engine
This is Rietveld 408576698