Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(183)

Side by Side Diff: sandbox/linux/tests/main.cc

Issue 273623002: Non-SFI NaCl: Stop running sandbox tests in components_unittests (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/at_exit.h" 5 #include "base/at_exit.h"
6 #include "base/logging.h" 6 #include "base/logging.h"
7 #include "base/test/test_suite.h" 7 #include "base/test/test_suite.h"
8 #include "sandbox/linux/tests/test_utils.h" 8 #include "sandbox/linux/tests/test_utils.h"
9 #include "sandbox/linux/tests/unit_tests.h" 9 #include "sandbox/linux/tests/unit_tests.h"
10 #include "testing/gtest/include/gtest/gtest.h" 10 #include "testing/gtest/include/gtest/gtest.h"
11 11
12 namespace sandbox { 12 namespace sandbox {
Mark Seaborn 2014/05/08 15:29:39 Can this "namespace sandbox" be dropped now? It o
jln (DO NOT USE THIS) 2014/05/08 16:30:02 Yeah, but it's the right idiom in sandbox/, no?. E
Mark Seaborn 2014/05/08 16:42:14 Oh, I see, yes, it does make a semantic difference
13
14 extern const bool kAllowForkWithThreads = false;
15
16 namespace { 13 namespace {
17 14
18 // Check for leaks in our tests. 15 // Check for leaks in our tests.
19 void RunPostTestsChecks() { 16 void RunPostTestsChecks() {
20 if (TestUtils::CurrentProcessHasChildren()) { 17 if (TestUtils::CurrentProcessHasChildren()) {
21 LOG(ERROR) << "One of the tests created a child that was not waited for. " 18 LOG(ERROR) << "One of the tests created a child that was not waited for. "
22 << "Please, clean-up after your tests!"; 19 << "Please, clean-up after your tests!";
23 } 20 }
24 } 21 }
25 22
(...skipping 13 matching lines...) Expand all
39 ::testing::FLAGS_gtest_death_test_style = "threadsafe"; 36 ::testing::FLAGS_gtest_death_test_style = "threadsafe";
40 #if defined(OS_ANDROID) 37 #if defined(OS_ANDROID)
41 int tests_result = RUN_ALL_TESTS(); 38 int tests_result = RUN_ALL_TESTS();
42 #else 39 #else
43 int tests_result = base::RunUnitTestsUsingBaseTestSuite(argc, argv); 40 int tests_result = base::RunUnitTestsUsingBaseTestSuite(argc, argv);
44 #endif 41 #endif
45 42
46 sandbox::RunPostTestsChecks(); 43 sandbox::RunPostTestsChecks();
47 return tests_result; 44 return tests_result;
48 } 45 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698