third_party/WebKit/LayoutTests/paint/invalidation/caret-change-paint-offset-keep-visual.html - Issue 2736213002: Fix caret paint invalidation issues

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/paint/invalidation/caret-change-paint-offset-keep-visual.html

Issue 2736213002: Fix caret paint invalidation issues (Closed)

Patch Set: - Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <div id="container" style="position: relative; overflow: hidden; width: 200px; h eight: 100px">

	3 <div style="width: 400px; height: 2px"></div>

	4   <input style="position: relative; top: 0; left: 0" id="input">

	5 </div>

	6 <script src="../../resources/run-after-layout-and-paint.js"></script>

	7 <script>

	8 onload = function() {

	9 input.focus();

	10 runAfterLayoutAndPaint(function() {

	11 container.scrollLeft = 56;
	chrishtr 2017/03/08 17:36:06 Does this layout test exercise the code about isIm Does this layout test exercise the code about isImmediateFullPaintInvalidationReason? Xianzhu 2017/03/08 19:38:22 Yes. Line 11 and 12 creates a situation that the i Show quoted text On 2017/03/08 17:36:06, chrishtr wrote: > Does this layout test exercise the code about > isImmediateFullPaintInvalidationReason? Yes. Line 11 and 12 creates a situation that the input (whose inner editor is the containing block of the caret) doesn't change its visual, but it needs repaint because its paint offset changes within its paint invalidation container. Our paint offset change detection logic will let the containing block's invalidatePaintIfNeeded() return a full invalidation reason.
	12 input.style.left = '56px';

	13 }, true);

	14 };

	15 </script>

OLD	NEW