Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(827)

Issue 2736133002: Add functionality for deleting previously indexed rulesets

Created:
3 years, 9 months ago by Charlie Harrison
Modified:
3 years, 7 months ago
Reviewers:
CC:
chromium-reviews, subresource-filter-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Add functionality for deleting previously indexed rulesets This code will be exercised when the ruleset verification fails. BUG=

Patch Set 1 #

Patch Set 2 : replacefile #

Patch Set 3 : update #

Patch Set 4 : fix unit tests #

Patch Set 5 : add browser test #

Patch Set 6 : rebase #

Messages

Total messages: 41 (41 generated)
Charlie Harrison
The CQ bit was checked by csharrison@chromium.org to run a CQ dry run
3 years, 9 months ago (2017-03-07 22:57:09 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2736133002/1
3 years, 9 months ago (2017-03-07 22:57:50 UTC) #2
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 9 months ago (2017-03-08 00:34:22 UTC) #3
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_rel_ng/builds/380086)
3 years, 9 months ago (2017-03-08 00:34:23 UTC) #4
Charlie Harrison
The CQ bit was checked by csharrison@chromium.org to run a CQ dry run
3 years, 9 months ago (2017-03-08 16:33:45 UTC) #5
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2736133002/20001
3 years, 9 months ago (2017-03-08 16:34:04 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 9 months ago (2017-03-08 18:43:46 UTC) #7
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/397093)
3 years, 9 months ago (2017-03-08 18:43:47 UTC) #8
Charlie Harrison
The CQ bit was checked by csharrison@chromium.org to run a CQ dry run
3 years, 7 months ago (2017-05-08 04:26:38 UTC) #9
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2736133002/40001
3 years, 7 months ago (2017-05-08 04:27:06 UTC) #10
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 7 months ago (2017-05-08 04:52:28 UTC) #11
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_asan_rel_ng/builds/364656) linux_chromium_chromeos_rel_ng on ...
3 years, 7 months ago (2017-05-08 04:52:29 UTC) #12
Charlie Harrison
The CQ bit was checked by csharrison@chromium.org to run a CQ dry run
3 years, 7 months ago (2017-05-08 13:27:31 UTC) #13
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2736133002/60001
3 years, 7 months ago (2017-05-08 13:27:44 UTC) #14
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 7 months ago (2017-05-08 15:14:23 UTC) #15
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
3 years, 7 months ago (2017-05-08 15:14:24 UTC) #16
Charlie Harrison
The CQ bit was checked by csharrison@chromium.org to run a CQ dry run
3 years, 7 months ago (2017-05-08 19:51:03 UTC) #17
Charlie Harrison
The CQ bit was checked by csharrison@chromium.org to run a CQ dry run
3 years, 7 months ago (2017-05-08 19:51:43 UTC) #18
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2736133002/60001
3 years, 7 months ago (2017-05-08 19:52:13 UTC) #19
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 7 months ago (2017-05-08 20:20:58 UTC) #20
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/430280)
3 years, 7 months ago (2017-05-08 20:20:59 UTC) #21
Charlie Harrison
The CQ bit was checked by csharrison@chromium.org to run a CQ dry run
3 years, 7 months ago (2017-05-08 22:11:12 UTC) #22
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2736133002/80001
3 years, 7 months ago (2017-05-08 22:11:52 UTC) #23
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 7 months ago (2017-05-08 22:51:14 UTC) #24
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/438804) win_chromium_x64_rel_ng on ...
3 years, 7 months ago (2017-05-08 22:51:15 UTC) #25
Charlie Harrison
The CQ bit was checked by csharrison@chromium.org to run a CQ dry run
3 years, 7 months ago (2017-05-09 13:13:27 UTC) #26
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2736133002/80001
3 years, 7 months ago (2017-05-09 13:13:52 UTC) #27
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 7 months ago (2017-05-09 13:20:35 UTC) #28
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_rel_ng/builds/421809)
3 years, 7 months ago (2017-05-09 13:20:36 UTC) #29
Charlie Harrison
The CQ bit was checked by csharrison@chromium.org to run a CQ dry run
3 years, 7 months ago (2017-05-09 14:05:11 UTC) #30
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2736133002/100001
3 years, 7 months ago (2017-05-09 14:05:32 UTC) #31
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 7 months ago (2017-05-09 14:14:27 UTC) #32
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/431118)
3 years, 7 months ago (2017-05-09 14:14:28 UTC) #33
Charlie Harrison
The CQ bit was checked by csharrison@chromium.org to run a CQ dry run
3 years, 7 months ago (2017-05-10 12:19:57 UTC) #34
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2736133002/100001
3 years, 7 months ago (2017-05-10 12:20:40 UTC) #35
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 7 months ago (2017-05-10 12:29:16 UTC) #36
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/432367)
3 years, 7 months ago (2017-05-10 12:29:18 UTC) #37
Charlie Harrison
The CQ bit was checked by csharrison@chromium.org to run a CQ dry run
3 years, 7 months ago (2017-05-22 17:48:49 UTC) #38
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2736133002/100001
3 years, 7 months ago (2017-05-22 17:49:42 UTC) #39
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 7 months ago (2017-05-22 18:00:16 UTC) #40
commit-bot: I haz the power
3 years, 7 months ago (2017-05-22 18:00:17 UTC) #41
Dry run: Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

Powered by Google App Engine
This is Rietveld 408576698