Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(347)

Unified Diff: tools/testrunner/network/network_execution.py

Issue 273613005: Run tests sorted by expected runtime. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/testrunner/network/network_execution.py
diff --git a/tools/testrunner/network/network_execution.py b/tools/testrunner/network/network_execution.py
index 0f53a6bb645bf2a757948e7656e6817a124349e8..4eee00696d8ebde6a46a50858b14dd837d2eac7f 100644
--- a/tools/testrunner/network/network_execution.py
+++ b/tools/testrunner/network/network_execution.py
@@ -33,7 +33,7 @@ import threading
import time
from . import distro
-from . import perfdata
+from ..local import perfdata
from ..local import execution
Jakob Kummerow 2014/05/14 17:41:42 nit: alpha-sort please
Michael Achenbach 2014/05/15 07:16:36 Was moving the file in the end... didn't see the o
from ..objects import peer
from ..objects import workpacket
@@ -54,6 +54,8 @@ class NetworkedRunner(execution.Runner):
self.suites = suites
num_tests = 0
datapath = os.path.join("out", "testrunner_data")
+ # TODO(machenbach): These fields should exist now in the superclass.
+ # But there is no super constructor call. Check if this is a problem.
Jakob Kummerow 2014/05/14 17:41:42 Shouldn't be a problem :-) Unifying Runner and Net
Michael Achenbach 2014/05/15 07:16:36 This TODO is just a remainder for when I might do
self.perf_data_manager = perfdata.PerfDataManager(datapath)
self.perfdata = self.perf_data_manager.GetStore(context.arch, context.mode)
for s in suites:

Powered by Google App Engine
This is Rietveld 408576698