Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(341)

Issue 273613005: Run tests sorted by expected runtime. (Closed)

Created:
6 years, 7 months ago by Michael Achenbach
Modified:
6 years, 7 months ago
Reviewers:
Jakob Kummerow
CC:
v8-dev
Visibility:
Public.

Description

Run tests sorted by expected runtime. BUG= R=jkummerow@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=21328

Patch Set 1 #

Patch Set 2 : #

Total comments: 6

Patch Set 3 : Review #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -121 lines) Patch
M tools/testrunner/local/execution.py View 1 2 4 chunks +12 lines, -1 line 0 comments Download
A + tools/testrunner/local/perfdata.py View 0 chunks +-1 lines, --1 lines 0 comments Download
M tools/testrunner/network/network_execution.py View 1 2 2 chunks +3 lines, -1 line 0 comments Download
D tools/testrunner/network/perfdata.py View 1 chunk +0 lines, -120 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Michael Achenbach
PTAL
6 years, 7 months ago (2014-05-14 15:13:17 UTC) #1
Michael Achenbach
Even test262 gets faster. Database size is ~2MB without and ~10MB with test262 per arch/mode. ...
6 years, 7 months ago (2014-05-14 15:33:19 UTC) #2
Jakob Kummerow
LGTM with nits. https://codereview.chromium.org/273613005/diff/2/tools/testrunner/local/execution.py File tools/testrunner/local/execution.py (right): https://codereview.chromium.org/273613005/diff/2/tools/testrunner/local/execution.py#newcode33 tools/testrunner/local/execution.py:33: from . import perfdata nit: alpha-sort ...
6 years, 7 months ago (2014-05-14 17:41:41 UTC) #3
Michael Achenbach
Done. Will investigate the stopability with Ctrl-C a bit more before landing... https://codereview.chromium.org/273613005/diff/2/tools/testrunner/network/network_execution.py File tools/testrunner/network/network_execution.py ...
6 years, 7 months ago (2014-05-15 07:16:36 UTC) #4
Michael Achenbach
6 years, 7 months ago (2014-05-15 12:02:25 UTC) #5
Message was sent while issue was closed.
Committed patchset #3 manually as r21328 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698