Issue 273613002: [FastTextAutosizer] Check for containingBlock in deepestBlockContainingAllText

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 273613002: [FastTextAutosizer] Check for containingBlock in deepestBlockContainingAllText (Closed)

Created:
6 years, 7 months ago by pdr.

Modified:
6 years, 7 months ago

Reviewers:
skobes

CC:
blink-reviews, blink-reviews-rendering, zoltan1, eae+blinkwatch, leviw+renderwatch, jchaffraix+rendering, pdr., rune+blink

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

[FastTextAutosizer] Check for containingBlock in deepestBlockContainingAllText This patch adds another speculative assert in deepestBlockContainingAllText to check for containingBlock() returning null which it can when the subtree is detached. I wasn't able to hit this in a synthetic test so this patch is a speculative fix. If this improves stability we can consider guarding all of the containingBlock() calls. BUG=370764 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=173581

Patch Set 1 #

Created: 6 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -1 line)			Patch
	M	Source/core/rendering/FastTextAutosizer.cpp	View		1 chunk	+3 lines, -1 line	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pdr@chromium.org/273613002/1

6 years, 7 months ago (2014-05-07 23:14:17 UTC) #4

Message was sent while issue was closed.

Change committed as 173581

Expand Messages | Collapse Messages