Use correct types on cloned constructors in mixin applications.

Use correct types on cloned constructors in mixin applications.

R=karlklose@google.com

Committed: https://github.com/dart-lang/sdk/commit/8608d1b43624017d91fe43eaa2ec5d75d01d7cd2

[ahe, 2017-03-08 13:37:32]

Patchset #2 (id:20001) has been deleted

[ahe, 2017-03-08 13:37:38]

Patchset #1 (id:1) has been deleted

[ahe, 2017-03-08 13:39:05]

ahe@google.com changed reviewers:
+ karlklose@google.com

[ahe, 2017-03-08 13:39:05]

@kustermann: I've moved compilation out of the quiet-zone. It no longer prints
any messages.
There are still messages being printed when computing dependencies.

https://codereview.chromium.org/2736103004/diff/40001/pkg/front_end/test/fast...
File pkg/front_end/test/fasta/rasta/bad_continue.dart.direct.expect (left):

https://codereview.chromium.org/2736103004/diff/40001/pkg/front_end/test/fast...
pkg/front_end/test/fasta/rasta/bad_continue.dart.direct.expect:8: break #L1;
I'm removing this bad expectation file: this should be a compile-time error, not
a break.

https://codereview.chromium.org/2736103004/diff/40001/pkg/front_end/test/fast...
File pkg/front_end/test/fasta/rasta/bad_interpolation.dart.direct.expect (left):

https://codereview.chromium.org/2736103004/diff/40001/pkg/front_end/test/fast...
pkg/front_end/test/fasta/rasta/bad_interpolation.dart.direct.expect:5: throw
"pkg/front_end/test/fasta/rasta/bad_interpolation.dart:246: \u0027[31mError:
ErrorKind.ExpectedString {actual: EOF}\u0027[0m";
I'm removing a bad expectation file. This should throw a compile-time error, not
a string.

[karlklose, 2017-03-08 14:00:06]

LGTM

https://codereview.chromium.org/2736103004/diff/40001/pkg/front_end/lib/src/f...
File pkg/front_end/lib/src/fasta/builder/class_builder.dart (right):

https://codereview.chromium.org/2736103004/diff/40001/pkg/front_end/lib/src/f...
pkg/front_end/lib/src/fasta/builder/class_builder.dart:124: // This method
returns null if the map is empty, and its behavior is
Use '///' here and below.

https://codereview.chromium.org/2736103004/diff/40001/pkg/front_end/lib/src/f...
pkg/front_end/lib/src/fasta/builder/class_builder.dart:148: break;
internal error?

[ahe, 2017-03-08 14:31:33]

PTAL, I substituted dynamic for missing type arguments.

https://codereview.chromium.org/2736103004/diff/40001/pkg/front_end/lib/src/f...
File pkg/front_end/lib/src/fasta/builder/class_builder.dart (right):

https://codereview.chromium.org/2736103004/diff/40001/pkg/front_end/lib/src/f...
pkg/front_end/lib/src/fasta/builder/class_builder.dart:124: // This method
returns null if the map is empty, and its behavior is
On 2017/03/08 14:00:06, karlklose wrote:
> Use '///' here and below.

Done.

https://codereview.chromium.org/2736103004/diff/40001/pkg/front_end/lib/src/f...
pkg/front_end/lib/src/fasta/builder/class_builder.dart:148: break;
On 2017/03/08 14:00:06, karlklose wrote:
> internal error?

Done.

[karlklose, 2017-03-09 09:44:26]

LGTM

[ahe, 2017-03-09 11:52:07]

Description was changed from

==========
Use correct types on cloned constructors in mixin applications.
==========

to

==========
Use correct types on cloned constructors in mixin applications.

R=karlklose@google.com

Committed:
https://github.com/dart-lang/sdk/commit/8608d1b43624017d91fe43eaa2ec5d75d01d7cd2
==========

[ahe, 2017-03-09 11:52:08]

Committed patchset #4 (id:100001) manually as
8608d1b43624017d91fe43eaa2ec5d75d01d7cd2 (presubmit successful).