Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(547)

Unified Diff: cc/surfaces/surface_manager.h

Issue 2736053004: SurfaceIds must be reusable as soon as their surfaces are marked destroyed (Closed)
Patch Set: Changed signature Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « cc/surfaces/surface_factory.cc ('k') | cc/surfaces/surface_manager.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: cc/surfaces/surface_manager.h
diff --git a/cc/surfaces/surface_manager.h b/cc/surfaces/surface_manager.h
index e4b6f17c5f6efd6e22edeca7795c5dfe9db6748d..8ecf28305c6a8265ab9aecfb542b614b3ab68f9b 100644
--- a/cc/surfaces/surface_manager.h
+++ b/cc/surfaces/surface_manager.h
@@ -65,11 +65,14 @@ class CC_SURFACES_EXPORT SurfaceManager {
void RequestSurfaceResolution(Surface* pending_surface);
- void RegisterSurface(Surface* surface);
void DeregisterSurface(const SurfaceId& surface_id);
jbauman 2017/03/09 22:21:37 Could you make this private while you're changing
Saman Sami 2017/03/09 22:32:04 Done.
+ std::unique_ptr<Surface> CreateSurface(
+ base::WeakPtr<SurfaceFactory> surface_factory,
+ const LocalSurfaceId& local_surface_id);
+
// Destroy the Surface once a set of sequence numbers has been satisfied.
- void Destroy(std::unique_ptr<Surface> surface);
+ void DestroySurface(std::unique_ptr<Surface> surface);
Surface* GetSurfaceForId(const SurfaceId& surface_id);
« no previous file with comments | « cc/surfaces/surface_factory.cc ('k') | cc/surfaces/surface_manager.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698