Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(356)

Issue 27360002: Remove variants block. (Closed)

Created:
7 years, 2 months ago by Nico
Modified:
7 years, 2 months ago
Reviewers:
scottmg
CC:
chromium-reviews, Lei Zhang
Visibility:
Public.

Description

Remove variants block. No existing gyp generator looks at this. (scons used to, but it hasn't been in use in over 3 years.) No behavior change. BUG=none R=scottmg@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=228730

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -13 lines) Patch
M build/common.gypi View 1 chunk +0 lines, -13 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Nico
7 years, 2 months ago (2013-10-15 16:56:23 UTC) #1
scottmg
lgtm
7 years, 2 months ago (2013-10-15 16:56:58 UTC) #2
Nico
7 years, 2 months ago (2013-10-15 18:30:19 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r228730 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698