Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(375)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/browser/memory/tab_manager.h

Issue 2735993002: memory_coordinator: Discard tabs under critical memory condition (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/memory/chrome_memory_coordinator_delegate.cc ('k') | chrome/browser/memory/tab_manager.cc » ('j') | content/browser/memory/memory_coordinator_impl.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/memory/tab_manager.h
diff --git a/chrome/browser/memory/tab_manager.h b/chrome/browser/memory/tab_manager.h
index c384b7e054b07fa3eb20ad6b794bd748fcaf5665..b0c2380ceeff7e24b485c419a4f4dffb1efe9b78 100644
--- a/chrome/browser/memory/tab_manager.h
+++ b/chrome/browser/memory/tab_manager.h
@@ -99,8 +99,9 @@ class TabManager : public TabStripModelObserver {
bool CanDiscardTab(int64_t target_web_contents_id) const;
// Discards a tab to free the memory occupied by its renderer. The tab still
- // exists in the tab-strip; clicking on it will reload it.
- void DiscardTab();
+ // exists in the tab-strip; clicking on it will reload it. Returns true if
+ // a tab is actually discarded.
haraken 2017/03/07 08:04:57 the tab was
+ bool DiscardTab();
// Discards a tab with the given unique ID. The tab still exists in the
// tab-strip; clicking on it will reload it. Returns null if the tab cannot
« no previous file with comments | « chrome/browser/memory/chrome_memory_coordinator_delegate.cc ('k') | chrome/browser/memory/tab_manager.cc » ('j') | content/browser/memory/memory_coordinator_impl.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698